Skip to content

flatcc: fix build with cmake4#451936

Merged
yayayayaka merged 1 commit intoNixOS:masterfrom
Sigmanificient:flat-cc-cmake-fix
Oct 15, 2025
Merged

flatcc: fix build with cmake4#451936
yayayayaka merged 1 commit intoNixOS:masterfrom
Sigmanificient:flat-cc-cmake-fix

Conversation

@Sigmanificient
Copy link
Member

@Sigmanificient Sigmanificient commented Oct 14, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@Sigmanificient Sigmanificient mentioned this pull request Oct 14, 2025
Open
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 14, 2025
@nix-owners nix-owners bot requested a review from onny October 14, 2025 12:33
LordGrimmauld
LordGrimmauld approved these changes Oct 14, 2025
View reviewed changes
Copy link
Contributor

@LordGrimmauld LordGrimmauld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patches seem to work. However, 0.6.1 is ancient, and while the tests still build, the fact we have half-changed and potentially mismatched build scripts makes me feel uneasy.

Maybe the better approach would be a bump to -unstable here? But approving, this does build and the tests should not have an impact on final build output.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 14, 2025
@yayayayaka
Copy link
Member

yayayayaka commented Oct 15, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 451936
Commit: c2bffe30d62f637f3b3f2a118180ba41b98eb003

x86_64-linux

✅ 1 package built:
  • flatcc

yayayayaka
yayayayaka approved these changes Oct 15, 2025
View reviewed changes
Copy link
Member

@yayayayaka yayayayaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can take care of updating the package in a separate PR.

@yayayayaka yayayayaka added this pull request to the merge queue Oct 15, 2025
Merged via the queue into NixOS:master with commit 5bf22c0 Oct 15, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LordGrimmauld LordGrimmauld LordGrimmauld approved these changes

@yayayayaka yayayayaka yayayayaka approved these changes

@onny onny Awaiting requested review from onny

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Sigmanificient @yayayayaka @LordGrimmauld