Skip to content

coin3d: Fix cmake 4 build#451909

Closed
Xmister wants to merge 1 commit intoNixOS:masterfrom
Xmister:patch-1
Closed

coin3d: Fix cmake 4 build#451909
Xmister wants to merge 1 commit intoNixOS:masterfrom
Xmister:patch-1

Conversation

@Xmister
Copy link

@Xmister Xmister commented Oct 14, 2025

Update cmake minimum version requirement in CMakeLists.txt.

Part of Cmake 4 update fixes: #445447

Things done

Removes 3.0-3.30 range from minimum version

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

Update cmake minimum version requirement in CMakeLists.txt.
@nixpkgs-ci nixpkgs-ci bot added the 12.first-time contribution This PR is the author's first one; please be gentle! label Oct 14, 2025
@qbisi
Copy link
Contributor

qbisi commented Oct 14, 2025

coin3d is not broken acording to hydra-check coin3d

cmake_minimum_required(VERSION 3.0...3.31) implies CMAKE_POLICY_VERSION = 3.31 which is compatible with cmake4.

ref: https://cmake.org/cmake/help/latest/command/cmake_minimum_required.html

@Xmister
Copy link
Author

Xmister commented Oct 14, 2025

coin3d is not broken acording to hydra-check coin3d

cmake_minimum_required(VERSION 3.0...3.31) implies CMAKE_POLICY_VERSION = 3.31 which is compatible with cmake4.

ref: https://cmake.org/cmake/help/latest/command/cmake_minimum_required.html

Right, I was using an earlier nixpkgs hash when it failed. Closing this.

@Xmister Xmister closed this Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tracking: Build Failures with CMake 4

2 participants