Skip to content

sqlcheck: fix minimum cmake version, mark as broken on darwin#451899

Merged
jopejoe1 merged 4 commits intoNixOS:masterfrom
h7x4:pkgs-sqlcheck-fix-cmake-version
Oct 15, 2025
Merged

sqlcheck: fix minimum cmake version, mark as broken on darwin#451899
jopejoe1 merged 4 commits intoNixOS:masterfrom
h7x4:pkgs-sqlcheck-fix-cmake-version

Conversation

@h7x4
Copy link
Member

@h7x4 h7x4 commented Oct 14, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@h7x4 h7x4 mentioned this pull request Oct 14, 2025
Open
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 14, 2025
@jopejoe1
Copy link
Member

jopejoe1 commented Oct 14, 2025

nixpkgs-review result for #451899

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 451899
Commit: dfc30953d4127c95f70f460beb62e84b8da712aa (subsequent changes)
Merge: 4a632da68500e6c9c2a9e8cfa28eb28c98d68d69

Logs: https://github.com/jopejoe1/nixpkgs-review-gha/actions/runs/18500821439

x86_64-linux

✅ 1 package built:
  • sqlcheck

aarch64-linux

✅ 1 package built:
  • sqlcheck

x86_64-darwin (sandbox = true)

❌ 1 package failed to build:
  • sqlcheck
Error logs: `x86_64-darwin`
sqlcheck 
In file included from /nix/build/nix-14269-3889298675/source/external/googletest/googletest/include/gtest/gtest.h:60:
In file included from /nix/build/nix-14269-3889298675/source/external/googletest/googletest/include/gtest/gtest-death-test.h:43:
In file included from /nix/build/nix-14269-3889298675/source/external/googletest/googletest/include/gtest/internal/gtest-death-test-internal.h:46:
In file included from /nix/build/nix-14269-3889298675/source/external/googletest/googletest/include/gtest/gtest-matchers.h:48:
/nix/build/nix-14269-3889298675/source/external/googletest/googletest/include/gtest/gtest-printers.h:473:35: error: implicit conversion from 'char16_t' to 'char32_t' may change the meaning of the represented code unit [-Werror,-Wcharacter-conversion]
  473 |   PrintTo(ImplicitCast_<char32_t>(c), os);
      |           ~~~~~~~~~~~~~           ^
[ 15%] Building CXX object external/gflags/CMakeFiles/gflags_nothreads_static.dir/src/gflags_reporting.cc.o
1 error generated.
make[2]: *** [CMakeFiles/googletest.dir/build.make:79: CMakeFiles/googletest.dir/external/googletest/googletest/src/gtest-all.cc.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:1117: CMakeFiles/googletest.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 19%] Building CXX object external/gflags/CMakeFiles/gflags_nothreads_static.dir/src/gflags_completions.cc.o
[ 23%] Building CXX object src/CMakeFiles/sqlcheck_library.dir/configuration.cpp.o
[ 26%] Building CXX object src/CMakeFiles/sqlcheck_library.dir/list.cpp.o
[ 30%] Linking CXX static library libgflags_nothreads.a
[ 30%] Built target gflags_nothreads_static
[ 34%] Linking CXX static library libsqlcheck_library.a
[ 34%] Built target sqlcheck_library
make: *** [Makefile:166: all] Error 2

aarch64-darwin (sandbox = true)

❌ 1 package failed to build:
  • sqlcheck
Error logs: `aarch64-darwin`
sqlcheck 
In file included from /nix/build/nix-5470-692720133/source/external/googletest/googletest/include/gtest/gtest.h:60:
In file included from /nix/build/nix-5470-692720133/source/external/googletest/googletest/include/gtest/gtest-death-test.h:43:
In file included from /nix/build/nix-5470-692720133/source/external/googletest/googletest/include/gtest/internal/gtest-death-test-internal.h:46:
In file included from /nix/build/nix-5470-692720133/source/external/googletest/googletest/include/gtest/gtest-matchers.h:48:
/nix/build/nix-5470-692720133/source/external/googletest/googletest/include/gtest/gtest-printers.h:473:35: error: implicit conversion from 'char16_t' to 'char32_t' may change the meaning of the represented code unit [-Werror,-Wcharacter-conversion]
  473 |   PrintTo(ImplicitCast_<char32_t>(c), os);
      |           ~~~~~~~~~~~~~           ^
[ 15%] Building CXX object external/gflags/CMakeFiles/gflags_nothreads_static.dir/src/gflags_reporting.cc.o
1 error generated.
make[2]: *** [CMakeFiles/googletest.dir/build.make:79: CMakeFiles/googletest.dir/external/googletest/googletest/src/gtest-all.cc.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:1117: CMakeFiles/googletest.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 19%] Building CXX object external/gflags/CMakeFiles/gflags_nothreads_static.dir/src/gflags_completions.cc.o
[ 23%] Building CXX object src/CMakeFiles/sqlcheck_library.dir/configuration.cpp.o
[ 26%] Building CXX object src/CMakeFiles/sqlcheck_library.dir/list.cpp.o
[ 30%] Linking CXX static library libgflags_nothreads.a
[ 30%] Built target gflags_nothreads_static
[ 34%] Linking CXX static library libsqlcheck_library.a
[ 34%] Built target sqlcheck_library
make: *** [Makefile:166: all] Error 2

@h7x4 h7x4 changed the title sqlcheck: fix minimum cmake version sqlcheck: fix minimum cmake version, mark as broken on darwin Oct 14, 2025
@h7x4 h7x4 requested a review from jopejoe1 October 14, 2025 15:29
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. and removed 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 14, 2025
@jopejoe1 jopejoe1 added this pull request to the merge queue Oct 15, 2025
Merged via the queue into NixOS:master with commit cac694a Oct 15, 2025
28 checks passed
@h7x4 h7x4 deleted the pkgs-sqlcheck-fix-cmake-version branch October 31, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jopejoe1 jopejoe1 jopejoe1 approved these changes

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@h7x4 @jopejoe1