Skip to content

Fix cmake builds #445447#451892

Merged
JohnRTitor merged 6 commits intoNixOS:masterfrom
Svenum:fix-cmake-builds
Oct 24, 2025
Merged

Fix cmake builds #445447#451892
JohnRTitor merged 6 commits intoNixOS:masterfrom
Svenum:fix-cmake-builds

Conversation

@Svenum
Copy link
Member

@Svenum Svenum commented Oct 14, 2025 •
edited
Loading

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Fixes builds from: #445447

This PR fixes:

  • audiality2
  • bowtie2
  • bustools
  • qstopmotion
  • chiaki
  • clfft

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. and removed 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Oct 14, 2025
@Sigmanificient Sigmanificient mentioned this pull request Oct 14, 2025
Open
@Svenum Svenum requested a review from LordGrimmauld October 14, 2025 08:50
LordGrimmauld
LordGrimmauld previously requested changes Oct 14, 2025
View reviewed changes
Copy link
Contributor

@LordGrimmauld LordGrimmauld left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should prefer patches, see also #445447 (comment).

CLI flag will silently do potentially unexpected things once upstream updates their cmake things, while patches will hard-fail at build time. This means patches won't be forgotten and will eventually be removed.

@Svenum Svenum requested review from LordGrimmauld and pSub October 14, 2025 12:39
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Oct 14, 2025
@Svenum Svenum marked this pull request as ready for review October 14, 2025 21:54
@nix-owners nix-owners bot requested review from fgaz and rybern October 14, 2025 21:57
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. and removed 2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Oct 14, 2025
@nixpkgs-ci nixpkgs-ci bot added 6.topic: games Gaming on NixOS 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. and removed 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Oct 16, 2025
@nix-owners nix-owners bot requested a review from ttuegel October 16, 2025 08:51
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. and removed 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Oct 16, 2025
@nix-owners nix-owners bot requested a review from chessai October 16, 2025 09:20
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Oct 19, 2025
@Svenum
Copy link
Member Author

Svenum commented Oct 21, 2025

@LordGrimmauld feel free to merge. I have no time to fix more. I will open a new PR if I have time again.

@nixpkgs-ci nixpkgs-ci bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Oct 21, 2025
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. and removed 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. labels Oct 22, 2025
@JohnRTitor JohnRTitor dismissed LordGrimmauld’s stale review October 24, 2025 01:02

changes requested fulfilled

@JohnRTitor JohnRTitor added this pull request to the merge queue Oct 24, 2025
Merged via the queue into NixOS:master with commit 7b443cf Oct 24, 2025
30 of 33 checks passed
@Svenum Svenum deleted the fix-cmake-builds branch October 24, 2025 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LordGrimmauld LordGrimmauld Awaiting requested review from LordGrimmauld

@pSub pSub Awaiting requested review from pSub

@fgaz fgaz Awaiting requested review from fgaz

@rybern rybern Awaiting requested review from rybern

@ttuegel ttuegel Awaiting requested review from ttuegel

@chessai chessai Awaiting requested review from chessai

Assignees

No one assigned

Labels

6.topic: games Gaming on NixOS 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Svenum @LordGrimmauld @JohnRTitor