Skip to content

mudlet: 4.17.2 -> 4.19.1#451846

Merged
vcunat merged 2 commits intoNixOS:masterfrom
netcrns:update-mudlet
Oct 27, 2025
Merged

mudlet: 4.17.2 -> 4.19.1#451846
vcunat merged 2 commits intoNixOS:masterfrom
netcrns:update-mudlet

Conversation

@netcrns
Copy link
Contributor

@netcrns netcrns commented Oct 14, 2025 •
edited
Loading

updating from 4.17.2 to 4.19.1!

as per #445447, this introduces an upstream patch to update cmake_minimum_required to 3.25.1 (thanks to @iedame for making sure this works)

this also removes the darwin-AppKit patch, as that commit is merged in Mudlet-4.19.1

builds for darwin are marked as broken for now

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@netcrns
Copy link
Contributor Author

netcrns commented Oct 14, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 451846
Commit: 9689a8d5ab3be1bcb809d499e3581e46a4ed72ad

x86_64-linux

✅ 1 package built:
  • mudlet

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 14, 2025
@nix-owners nix-owners bot requested a review from pstn October 14, 2025 03:31
@nixpkgs-ci nixpkgs-ci bot added the 6.topic: games Gaming on NixOS label Oct 14, 2025
@netcrns
Copy link
Contributor Author

netcrns commented Oct 18, 2025

oh my bad, didn't know about #389652

@netcrns netcrns closed this Oct 18, 2025
@iedame iedame mentioned this pull request Oct 23, 2025
Closed
13 tasks
@iedame
Copy link
Contributor

iedame commented Oct 23, 2025

As per #389652 (comment) is it okay if we proceed with your PR @netcrns?

@iedame iedame reopened this Oct 23, 2025
@iedame

This comment was marked as duplicate.

Sign in to view
@iedame

This comment was marked as outdated.

Sign in to view
@iedame

This comment was marked as outdated.

Sign in to view
@iedame

This comment was marked as outdated.

Sign in to view
@iedame
Copy link
Contributor

iedame commented Oct 23, 2025 •
edited
Loading

Nope, this happened right by the end:

fatal error: 'Sparkle/Sparkle.h' file not found

I guess we need to disable sparkle updater?

Maybe this at cmakeFlags?
"-DUSE_UPDATER=OFF"
or
WITH_UPDATER=NO

@TheWanderingCrow
Copy link
Contributor

TheWanderingCrow commented Oct 23, 2025

This was a similar issue when I first opened my PR, it was building successfully for me with CMAKE 3.10 and 3.25.1

WITH_UPDATER=NO is already set but there was an issue with it still being compiled in the source

@iedame
Copy link
Contributor

iedame commented Oct 23, 2025

I see, I guess it is okay to mark darwin as broken and we can start another PR to fix it later.

@netcrns netcrns force-pushed the update-mudlet branch 2 times, most recently from b8a9500 to c34602e Compare October 23, 2025 17:18
iedame
iedame reviewed Oct 23, 2025
View reviewed changes
iedame
iedame reviewed Oct 23, 2025
View reviewed changes
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. and removed 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. labels Oct 23, 2025
@iedame iedame mentioned this pull request Oct 23, 2025
Closed
13 tasks
iedame
iedame reviewed Oct 23, 2025
View reviewed changes
@iedame
Copy link
Contributor

iedame commented Oct 23, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 451846
Commit: 79c00299165d76903b1763632feb429593c118f2 (subsequent changes)
Merge: 96030e2e3bbb4ec922192ce67b48611613d457b9

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18757681430

x86_64-linux

✅ 1 package built:
  • mudlet

aarch64-linux

✅ 1 package built:
  • mudlet

x86_64-darwin

✅ No rebuilds

aarch64-darwin

✅ No rebuilds

@netcrns
Copy link
Contributor Author

netcrns commented Oct 23, 2025

oh, i should probably edit the commit message to reflect current changes, right?

@iedame
Copy link
Contributor

iedame commented Oct 23, 2025

oh, i should probably edit the commit message to reflect current changes, right?

Yeah, that will definitely be helpful. PR message too.

@netcrns
mudlet: 4.17.2 -> 4.19.1
088889b 
as per NixOS#445447, this introduces an upstream patch
to update `cmake_minimum_required` to `3.25.1`
(thanks to @iedame for making sure this works)

this also removes the darwin-AppKit patch, as that
commit is merged in `Mudlet-4.19.1`
@netcrns
mudlet: mark darwin as broken
d8f5224
iedame
iedame approved these changes Oct 23, 2025
View reviewed changes
Copy link
Contributor

@iedame iedame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@iedame iedame requested a review from Sigmanificient October 23, 2025 18:56
@iedame
Copy link
Contributor

iedame commented Oct 23, 2025

@Sigmanificient May we have your help here to review/merge please? 😄 This one is in the cmake4 list and had 3 open PRs but none ever got enough traction to be merged. Fingers crossed!

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 23, 2025
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Oct 25, 2025
felixalbrigtsen
felixalbrigtsen approved these changes Oct 27, 2025
View reviewed changes
Copy link
Member

@felixalbrigtsen felixalbrigtsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is sad to break Darwin on an otherwise working package, but as I didn't get further after #389652 (comment), and the SparkleUpdater looks to be more stubborn than what I can fix today, it should be fine to merge this PR, and I or someone else can fix Darwin asynchronously.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 3+ This PR was reviewed and approved by three or more persons. and removed 12.approvals: 2 This PR was reviewed and approved by two persons. labels Oct 27, 2025
@iedame
Copy link
Contributor

iedame commented Oct 27, 2025

Indeed, but feel free to open a separate PR to fix Darwin and ping me and/or NixOS/darwin-maintainers for help if you do. Hopefully we can get this merged and building again, last hydra build was in September https://hydra.nixos.org/build/310418066

Darwin support will probably need some updater workaround like previous versions.

@vcunat vcunat added this pull request to the merge queue Oct 27, 2025
Merged via the queue into NixOS:master with commit 2a5b2e0 Oct 27, 2025
32 of 34 checks passed
@netcrns netcrns deleted the update-mudlet branch October 29, 2025 16:58
@h7x4 h7x4 mentioned this pull request Oct 31, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pstn pstn Awaiting requested review from pstn

@Sigmanificient Sigmanificient Awaiting requested review from Sigmanificient

3 more reviewers

@iedame iedame iedame approved these changes

@cpu cpu cpu approved these changes

@felixalbrigtsen felixalbrigtsen felixalbrigtsen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: games Gaming on NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 3+ This PR was reviewed and approved by three or more persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@netcrns @iedame @TheWanderingCrow @cpu @felixalbrigtsen @vcunat