Skip to content

infra-arcana: cmake 4 patches#451803

Merged
LordGrimmauld merged 1 commit intoNixOS:masterfrom
netcrns:ia-cmake4
Oct 14, 2025
Merged

infra-arcana: cmake 4 patches#451803
LordGrimmauld merged 1 commit intoNixOS:masterfrom
netcrns:ia-cmake4

Conversation

@netcrns
Copy link
Contributor

@netcrns netcrns commented Oct 13, 2025

Haven't contributed in a while, just wanted to get this game working for October so lmk if something's not up to guidelines.

Added patches from upstream.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 13, 2025
@nix-owners nix-owners bot requested a review from kenranunderscore October 13, 2025 21:48
@nixpkgs-ci nixpkgs-ci bot added 9.needs: reviewer This PR currently has no reviewers requested and needs attention. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 13, 2025
@netcrns
Copy link
Contributor Author

netcrns commented Oct 13, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 451803
Commit: 3cfaca272d65982e8d94d3ecabe1d36b35e13e0e


x86_64-linux

✅ 1 package built:
  • infra-arcana

@Sigmanificient
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 451803
Commit: 3cfaca272d65982e8d94d3ecabe1d36b35e13e0e (subsequent changes)
Merge: 1efbb66d2df5f50d46a2f105fd0fb0a371db7c5d

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/18480973374


x86_64-linux

✅ 1 package built:
  • infra-arcana

aarch64-linux

✅ 1 package built:
  • infra-arcana

x86_64-darwin

No rebuilds


aarch64-darwin

No rebuilds

Copy link
Contributor

@LordGrimmauld LordGrimmauld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, built on x86_64-linux, patches look sane.

@LordGrimmauld LordGrimmauld added this pull request to the merge queue Oct 14, 2025
Merged via the queue into NixOS:master with commit af79d15 Oct 14, 2025
35 of 38 checks passed
@netcrns netcrns deleted the ia-cmake4 branch October 14, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants