Skip to content

tini: add patch for cmake minimum version#451640

Merged
SuperSandro2000 merged 2 commits intoNixOS:masterfrom
rorosen:tini-cmake-fix
Oct 13, 2025
Merged

tini: add patch for cmake minimum version#451640
SuperSandro2000 merged 2 commits intoNixOS:masterfrom
rorosen:tini-cmake-fix

Conversation

@rorosen
Copy link
Contributor

@rorosen rorosen commented Oct 13, 2025 •
edited
Loading

Things done

#445447

Closes #451667

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 13, 2025
@SuperSandroBot

This comment was marked as outdated.

Sign in to view
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 6.topic: docker tools Open-source software for deploying and running of containerized applications and removed 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Oct 13, 2025
@rorosen
Copy link
Contributor Author

rorosen commented Oct 13, 2025

Didn't see that there is a docker-tini derivation that uses a different revision. The second commit unsets the patches for docker-tini so there are no failing packages anymore.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 451640
Commit: 12828f1fa027d9b09bbec49b3a553263514c9aed

x86_64-linux

✅ 2 packages built:
  • nixpkgs-manual
  • tini

@SuperSandroBot
Copy link

SuperSandroBot commented Oct 13, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 451640
Commit: 12828f1fa027d9b09bbec49b3a553263514c9aed (subsequent changes)
Merge: 8dbafcd34ea0f0dd2b39ef8041bd48f9b2246876

Logs: https://github.com/SuperSandro2000/nixpkgs-review-gha/actions/runs/18467809618

x86_64-linux

✅ 1 package built:
  • tini

aarch64-linux

✅ 1 package built:
  • tini

x86_64-darwin

✅ No rebuilds

aarch64-darwin

✅ No rebuilds

@SuperSandro2000 SuperSandro2000 added this pull request to the merge queue Oct 13, 2025
Merged via the queue into NixOS:master with commit e73b585 Oct 13, 2025
31 of 34 checks passed
@Sigmanificient Sigmanificient mentioned this pull request Oct 14, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

Assignees

No one assigned

Labels

6.topic: docker tools Open-source software for deploying and running of containerized applications 9.needs: reviewer This PR currently has no reviewers requested and needs attention. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Build failure: tini

3 participants

@rorosen @SuperSandroBot @SuperSandro2000