Skip to content

tint2: fix build with CMake 4#451616

Merged
teto merged 3 commits intoNixOS:masterfrom
SFrijters:tint2-cmake4
Oct 14, 2025
Merged

tint2: fix build with CMake 4#451616
teto merged 3 commits intoNixOS:masterfrom
SFrijters:tint2-cmake4

Conversation

@SFrijters
Copy link
Member

#445447

I have an upstream PR for another (CMake) issue from seven months ago that was never responded to, so I figure we need to just fix this on our side as well.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

Also fix a warning about calling 'project' before setting the minimum required version.
@SFrijters SFrijters changed the title tint2: Fix build with CMake 4 tint2: fix build with CMake 4 Oct 13, 2025
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 13, 2025
@nix-owners nix-owners bot requested a review from romildo October 13, 2025 09:47
@Sigmanificient
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 451616
Commit: 0c9e2f7605a188f340a10fc0b2bd0fc83db1354b (subsequent changes)
Merge: 2e04b4bf313a4e76e05ae226f5142e9af06161e6

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/18480838327


x86_64-linux

✅ 1 package built:
  • tint2

aarch64-linux

✅ 1 package built:
  • tint2

@teto teto added this pull request to the merge queue Oct 14, 2025
Merged via the queue into NixOS:master with commit b6e47f2 Oct 14, 2025
26 checks passed
@SFrijters SFrijters deleted the tint2-cmake4 branch October 14, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants