Skip to content

percona-xtrabackup_{8_4,8_0}: update to fix build with cmake4#451612

Merged
vcunat merged 2 commits intoNixOS:masterfrom
flyingcircusio:push-zsnvultwrsru
Oct 19, 2025
Merged

percona-xtrabackup_{8_4,8_0}: update to fix build with cmake4#451612
vcunat merged 2 commits intoNixOS:masterfrom
flyingcircusio:push-zsnvultwrsru

Conversation

@leona-ya
Copy link
Member

@leona-ya leona-ya commented Oct 13, 2025 •
edited by Sigmanificient
Loading

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 13, 2025
@Sigmanificient
Copy link
Member

Sigmanificient commented Oct 14, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 451612
Commit: 2e64dde5648bdd6367d57bd4388b2c8b4fc0281c (subsequent changes)
Merge: 52948221e127e15b9edec0567efa59e0a011facf

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/18480838586

x86_64-linux

❌ 1 package failed to build:
  • percona-xtrabackup_8_0
✅ 1 package built:
  • percona-xtrabackup (percona-xtrabackup_8_4)

aarch64-linux

❌ 2 packages failed to build:
  • percona-xtrabackup (percona-xtrabackup_8_4)
  • percona-xtrabackup_8_0
Error logs: `aarch64-linux`
percona-xtrabackup 
[ 26%] Building CXX object extra/icu/CMakeFiles/icui18n.dir/icu-release-73-1/source/i18n/uregexc.cpp.o
[ 26%] Building CXX object extra/icu/CMakeFiles/icui18n.dir/icu-release-73-1/source/i18n/uregex.cpp.o
[ 27%] Building CXX object extra/icu/CMakeFiles/icui18n.dir/icu-release-73-1/source/i18n/uregion.cpp.o
[ 27%] Building CXX object extra/icu/CMakeFiles/icui18n.dir/icu-release-73-1/source/i18n/usearch.cpp.o
[ 27%] Building CXX object extra/icu/CMakeFiles/icui18n.dir/icu-release-73-1/source/i18n/uspoof_build.cpp.o
[ 27%] Building CXX object extra/icu/CMakeFiles/icui18n.dir/icu-release-73-1/source/i18n/uspoof_conf.cpp.o
[ 27%] Building CXX object extra/icu/CMakeFiles/icui18n.dir/icu-release-73-1/source/i18n/uspoof.cpp.o
[ 27%] Building CXX object extra/icu/CMakeFiles/icui18n.dir/icu-release-73-1/source/i18n/uspoof_impl.cpp.o
[ 27%] Building CXX object extra/icu/CMakeFiles/icui18n.dir/icu-release-73-1/source/i18n/utf16collationiterator.cpp.o
[ 27%] Building CXX object extra/icu/CMakeFiles/icui18n.dir/icu-release-73-1/source/i18n/utf8collationiterator.cpp.o
[ 27%] Building CXX object extra/icu/CMakeFiles/icui18n.dir/icu-release-73-1/source/i18n/utmscale.cpp.o
[ 27%] Building CXX object extra/icu/CMakeFiles/icui18n.dir/icu-release-73-1/source/i18n/utrans.cpp.o
[ 27%] Building CXX object extra/icu/CMakeFiles/icui18n.dir/icu-release-73-1/source/i18n/vtzone.cpp.o
[ 27%] Building CXX object extra/icu/CMakeFiles/icui18n.dir/icu-release-73-1/source/i18n/vzone.cpp.o
[ 27%] Building CXX object extra/icu/CMakeFiles/icui18n.dir/icu-release-73-1/source/i18n/zonemeta.cpp.o
[ 27%] Building CXX object extra/icu/CMakeFiles/icui18n.dir/icu-release-73-1/source/i18n/zrule.cpp.o
[ 27%] Building CXX object extra/icu/CMakeFiles/icui18n.dir/icu-release-73-1/source/i18n/ztrans.cpp.o
[ 27%] Linking CXX static library libicui18n.a
[ 27%] Built target icui18n
make: *** [Makefile:156: all] Error 2

@Sigmanificient Sigmanificient mentioned this pull request Oct 14, 2025
Open
@leona-ya
percona-xtrabackup_8_0: 8.0.35-32 -> 8.0.35-34
87bb45f 
This change fixes the build with CMake4
@leona-ya
percona-xtrabackup_8_4: 8.4.0-2 -> 8.4.0-4
3957c76 
This change fixes the build with CMake4
@leona-ya
Copy link
Member Author

leona-ya commented Oct 14, 2025

🤦 thank you, fixed on x86_64-linux at least. For aarch64-linux I first need to get to a machine later, the logs you posted aren't really helpful

@grimmauld-bot
Copy link

grimmauld-bot commented Oct 14, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 451612
Commit: 3957c7612e702da6c26fc225f922a7c4526144e3

x86_64-linux

✅ 2 packages built:
  • percona-xtrabackup (percona-xtrabackup_8_4)
  • percona-xtrabackup_8_0

1 similar comment
@grimmauld-bot

This comment was marked as duplicate.

Sign in to view
@LordGrimmauld
Copy link
Contributor

LordGrimmauld commented Oct 15, 2025

The aarch64 build failure seems to be protobuf fallout:

percona-xtrabackup> In file included from /nix/store/1w9h5xlfcvcb27jjdrgchg1kwjvmsv1g-protobuf-32.1/include/google/protobuf/arena.h:36,
percona-xtrabackup>                  from /build/source/build/sql/protobuf/generated/protobuf_lite/replication_asynchronous_connection_failover.pb.h:21,
percona-xtrabackup>                  from /build/source/build/sql/protobuf/generated/protobuf_lite/replication_asynchronous_connection_failover.pb.cc:6:
percona-xtrabackup> /nix/store/1w9h5xlfcvcb27jjdrgchg1kwjvmsv1g-protobuf-32.1/include/google/protobuf/port.h: In function 'uint32_t google::protobuf::internal::Crc32(uint32_t, uint64_t)':
percona-xtrabackup> /nix/store/1w9h5xlfcvcb27jjdrgchg1kwjvmsv1g-protobuf-32.1/include/google/protobuf/port.h:798:10: error: '__builtin_arm_crc32cd'percona-xtrabackup>       |          __builtin_aarch64_crc32cx

It is however somewhere in the code gen, so i am not sure about where to go and fix it.

@grimmauld-bot

This comment was marked as off-topic.

Sign in to view
@LordGrimmauld
Copy link
Contributor

LordGrimmauld commented Oct 15, 2025

Sorry for the noise, got the wrong clipboard again... One time i'll get it!

@Sigmanificient
Copy link
Member

Sigmanificient commented Oct 15, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 451612
Commit: 3957c7612e702da6c26fc225f922a7c4526144e3 (subsequent changes)
Merge: 09a5f2ecc4f6226d12bf0cb101581a1967fd0d9e

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/18526719980

x86_64-linux

✅ 2 packages built:
  • percona-xtrabackup (percona-xtrabackup_8_4)
  • percona-xtrabackup_8_0

aarch64-linux

❌ 2 packages failed to build:
  • percona-xtrabackup (percona-xtrabackup_8_4)
  • percona-xtrabackup_8_0
Error logs: `aarch64-linux`
percona-xtrabackup 
[ 26%] Building CXX object extra/icu/CMakeFiles/icui18n.dir/icu-release-73-1/source/i18n/uregexc.cpp.o
[ 26%] Building CXX object extra/icu/CMakeFiles/icui18n.dir/icu-release-73-1/source/i18n/uregex.cpp.o
[ 27%] Building CXX object extra/icu/CMakeFiles/icui18n.dir/icu-release-73-1/source/i18n/uregion.cpp.o
[ 27%] Building CXX object extra/icu/CMakeFiles/icui18n.dir/icu-release-73-1/source/i18n/usearch.cpp.o
[ 27%] Building CXX object extra/icu/CMakeFiles/icui18n.dir/icu-release-73-1/source/i18n/uspoof_build.cpp.o
[ 27%] Building CXX object extra/icu/CMakeFiles/icui18n.dir/icu-release-73-1/source/i18n/uspoof_conf.cpp.o
[ 27%] Building CXX object extra/icu/CMakeFiles/icui18n.dir/icu-release-73-1/source/i18n/uspoof.cpp.o
[ 27%] Building CXX object extra/icu/CMakeFiles/icui18n.dir/icu-release-73-1/source/i18n/uspoof_impl.cpp.o
[ 27%] Building CXX object extra/icu/CMakeFiles/icui18n.dir/icu-release-73-1/source/i18n/utf16collationiterator.cpp.o
[ 27%] Building CXX object extra/icu/CMakeFiles/icui18n.dir/icu-release-73-1/source/i18n/utf8collationiterator.cpp.o
[ 27%] Building CXX object extra/icu/CMakeFiles/icui18n.dir/icu-release-73-1/source/i18n/utmscale.cpp.o
[ 27%] Building CXX object extra/icu/CMakeFiles/icui18n.dir/icu-release-73-1/source/i18n/utrans.cpp.o
[ 27%] Building CXX object extra/icu/CMakeFiles/icui18n.dir/icu-release-73-1/source/i18n/vtzone.cpp.o
[ 27%] Building CXX object extra/icu/CMakeFiles/icui18n.dir/icu-release-73-1/source/i18n/vzone.cpp.o
[ 27%] Building CXX object extra/icu/CMakeFiles/icui18n.dir/icu-release-73-1/source/i18n/zonemeta.cpp.o
[ 27%] Building CXX object extra/icu/CMakeFiles/icui18n.dir/icu-release-73-1/source/i18n/zrule.cpp.o
[ 27%] Building CXX object extra/icu/CMakeFiles/icui18n.dir/icu-release-73-1/source/i18n/ztrans.cpp.o
[ 27%] Linking CXX static library libicui18n.a
[ 27%] Built target icui18n
make: *** [Makefile:156: all] Error 2
percona-xtrabackup_8_0 
[ 26%] Building CXX object extra/icu/CMakeFiles/icui18n.dir/icu-release-73-1/source/i18n/uregexc.cpp.o
[ 26%] Building CXX object extra/icu/CMakeFiles/icui18n.dir/icu-release-73-1/source/i18n/uregex.cpp.o
[ 26%] Building CXX object extra/icu/CMakeFiles/icui18n.dir/icu-release-73-1/source/i18n/uregion.cpp.o
[ 26%] Building CXX object extra/icu/CMakeFiles/icui18n.dir/icu-release-73-1/source/i18n/usearch.cpp.o
[ 26%] Building CXX object extra/icu/CMakeFiles/icui18n.dir/icu-release-73-1/source/i18n/uspoof_build.cpp.o
[ 26%] Building CXX object extra/icu/CMakeFiles/icui18n.dir/icu-release-73-1/source/i18n/uspoof_conf.cpp.o
[ 26%] Building CXX object extra/icu/CMakeFiles/icui18n.dir/icu-release-73-1/source/i18n/uspoof.cpp.o
[ 26%] Building CXX object extra/icu/CMakeFiles/icui18n.dir/icu-release-73-1/source/i18n/uspoof_impl.cpp.o
[ 26%] Building CXX object extra/icu/CMakeFiles/icui18n.dir/icu-release-73-1/source/i18n/utf16collationiterator.cpp.o
[ 26%] Building CXX object extra/icu/CMakeFiles/icui18n.dir/icu-release-73-1/source/i18n/utf8collationiterator.cpp.o
[ 26%] Building CXX object extra/icu/CMakeFiles/icui18n.dir/icu-release-73-1/source/i18n/utmscale.cpp.o
[ 26%] Building CXX object extra/icu/CMakeFiles/icui18n.dir/icu-release-73-1/source/i18n/utrans.cpp.o
[ 26%] Building CXX object extra/icu/CMakeFiles/icui18n.dir/icu-release-73-1/source/i18n/vtzone.cpp.o
[ 26%] Building CXX object extra/icu/CMakeFiles/icui18n.dir/icu-release-73-1/source/i18n/vzone.cpp.o
[ 26%] Building CXX object extra/icu/CMakeFiles/icui18n.dir/icu-release-73-1/source/i18n/zonemeta.cpp.o
[ 26%] Building CXX object extra/icu/CMakeFiles/icui18n.dir/icu-release-73-1/source/i18n/zrule.cpp.o
[ 27%] Building CXX object extra/icu/CMakeFiles/icui18n.dir/icu-release-73-1/source/i18n/ztrans.cpp.o
[ 27%] Linking CXX static library libicui18n.a
[ 27%] Built target icui18n
make: *** [Makefile:156: all] Error 2

x86_64-darwin

✅ No rebuilds

aarch64-darwin

✅ No rebuilds

@vcunat vcunat added this pull request to the merge queue Oct 19, 2025
@vcunat
Copy link
Member

vcunat commented Oct 19, 2025

aarch64 is an older regression; let's not block fixing x86_64 on that.

Merged via the queue into NixOS:master with commit 6a8963b Oct 19, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

9.needs: reviewer This PR currently has no reviewers requested and needs attention. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@leona-ya @Sigmanificient @grimmauld-bot @LordGrimmauld @vcunat