Skip to content

qcomicbook: fix build issue with CMake 4#451544

Merged
dotlambda merged 1 commit intoNixOS:masterfrom
panchoh:fix/qcomicbook-cmake4-build
Oct 13, 2025
Merged

qcomicbook: fix build issue with CMake 4#451544
dotlambda merged 1 commit intoNixOS:masterfrom
panchoh:fix/qcomicbook-cmake4-build

Conversation

@panchoh
Copy link
Contributor

@panchoh panchoh commented Oct 13, 2025

See #445447.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@panchoh
Copy link
Contributor Author

panchoh commented Oct 13, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 451544
Commit: 11161f27df5576380f769bcde808e11e0b3d524e


x86_64-linux

✅ 1 package built:
  • qcomicbook

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 13, 2025
@nix-owners nix-owners bot requested a review from greydot October 13, 2025 03:48
@panchoh panchoh force-pushed the fix/qcomicbook-cmake4-build branch from a9245df to ba58304 Compare October 13, 2025 05:43
Co-authored-by: dotlambda <[email protected]># This is a combination of 2 commits.
@panchoh panchoh force-pushed the fix/qcomicbook-cmake4-build branch from ba58304 to 5265b29 Compare October 13, 2025 05:46
@dotlambda dotlambda added this pull request to the merge queue Oct 13, 2025
Merged via the queue into NixOS:master with commit 662e2ea Oct 13, 2025
28 of 31 checks passed
@panchoh panchoh deleted the fix/qcomicbook-cmake4-build branch October 13, 2025 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants