Skip to content

treewide: mark failing packages as broken#451447

Merged
mweinelt merged 1 commit intoNixOS:masterfrom
mdaniels5757:mark-broken
Dec 3, 2025
Merged

treewide: mark failing packages as broken#451447
mweinelt merged 1 commit intoNixOS:masterfrom
mdaniels5757:mark-broken

Conversation

@mdaniels5757
Copy link
Member

@mdaniels5757 mdaniels5757 commented Oct 12, 2025 •
edited
Loading

On 12 separate Hydra evaluations (which I selected for their relatively low failure numbers, and which span over a year), these packages have done nothing other than fail for all platforms.
That is, if a package had a status other than "Failed" on any platform for any of the selected evaluations, it is not included here.
For Python packages and Linux kernel modules, they also fail across all built Python versions (so if the package succeeds with Python 3.12 but fails with Python 3.13, it's not included here).

The marking itself was done with pkgs/common-updater/scripts/mark-broken, generation of the packages to be marked was done with a modification to https://git.helsinki.tools/janne.hess/zhf/-/commits/master and a custom Python script.

This should have 0 rebuilds.

Things done

  • 0 rebuilds.
  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 6.topic: python Python is a high-level, general-purpose programming language. labels Oct 12, 2025
@nix-owners nix-owners bot requested review from RaghavSood and mmahut October 12, 2025 19:57
@Sigmanificient
Copy link
Member

Sigmanificient commented Oct 12, 2025 •
edited
Loading

trilinos is 4 major behind!

qbisi
qbisi reviewed Oct 21, 2025
View reviewed changes
@qbisi
Copy link
Contributor

qbisi commented Oct 21, 2025 •
edited
Loading

trilinos is 4 major behind!

xyce can unpin trilions accroding to spack https://github.com/spack/spack-packages/blob/5ce2e954ef85769b410ce2550bac78382d75be27/repos/spack_repo/builtin/packages/xyce/package.py#L106

i will give it a try to upgrade trilinos since some of my packages (e.g. petsc) may optional rely on trilinos.

This was referenced Oct 22, 2025
Merged
Closed
@dotlambda dotlambda mentioned this pull request Oct 25, 2025
Merged
13 tasks
@iedame
Copy link
Contributor

iedame commented Oct 26, 2025

mirtk is fixed by #455650
mpifileutils was fixed by #454695
scipopt-gcg is fixed by #455397
trilinos and trilinos-mpi was fixed by #455656

Those are the ones I recognize from the cmake4 tracking list

@iedame
Copy link
Contributor

iedame commented Oct 26, 2025

cloudcompare was fixed by #454578
python3Packages.uqbar was fixed by #451495

@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 1, 2025
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Nov 1, 2025

Can we add a short comment why those packages where marked broken? Otherwise it is not easy to assess afterwards if it is worth fixing them or it can be just dropped.

@mdaniels5757 mdaniels5757 force-pushed the mark-broken branch 2 times, most recently from 22b3bf6 to 50d4848 Compare November 1, 2025 16:32
@mdaniels5757
Copy link
Member Author

mdaniels5757 commented Nov 1, 2025 •
edited
Loading

I added a more recent evaluation, which removed from this PR all of the packages iedame mentioned except scipopt-gcg, which I removed manually.

I also added a comment for each package.

@nixpkgs-ci nixpkgs-ci bot added 6.topic: php PHP is a general-purpose scripting language geared towards web development. and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Nov 1, 2025
qweered
qweered suggested changes Nov 1, 2025
View reviewed changes
@qbisi
Copy link
Contributor

qbisi commented Nov 1, 2025 •
edited
Loading

some packages failed due to cmake v4 error. e.g. itk_5_2/getdp. itk is not broken, only mark broken for itk version 5.2.

Also, getdp's original source url is not available anymore, the fix will be getdp 4.0 (currently 4.0 is not released).

@mdaniels5757 mdaniels5757 force-pushed the mark-broken branch 2 times, most recently from 9b07cb2 to 1f3b573 Compare November 1, 2025 17:31
@nix-owners nix-owners bot requested review from Ma27, aanderse, globin and talyz November 1, 2025 17:37
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 24, 2025
@mdaniels5757
treewide: mark failing packages as broken
1d64177 
On 16 separate Hydra evaluations (which I selected for their relatively
low failure numbers, and which span just over a year), these packages have done
nothing other than fail for all platforms.
For Python packages, they also fail across all built Python versions.
@nixpkgs-ci nixpkgs-ci bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 28, 2025
@mdaniels5757
Copy link
Member Author

mdaniels5757 commented Nov 28, 2025 •
edited
Loading

Rebased again, removed all packages that have been fixed as of https://hydra.nixos.org/eval/1820524 or dropped. Still no changes beyond running git checkout HEAD^ -- some/file (or fixing a merge conflict) and updating the comments.

lukegb
lukegb approved these changes Nov 28, 2025
View reviewed changes
Copy link
Contributor

@lukegb lukegb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good (at least from my perspective for oven-media-engine). Are you planning on marking these as broken in 25.11 as well?

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 3+ This PR was reviewed and approved by three or more persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. and removed 12.approvals: 2 This PR was reviewed and approved by two persons. labels Nov 28, 2025
@mdaniels5757
Copy link
Member Author

mdaniels5757 commented Nov 28, 2025 •
edited
Loading

Yes, I was going to backport this. Thanks for the reminder!

@mdaniels5757 mdaniels5757 added the backport release-25.11 Backport PR automatically label Nov 28, 2025
@mweinelt mweinelt added this pull request to the merge queue Dec 3, 2025
Merged via the queue into NixOS:master with commit d392473 Dec 3, 2025
32 of 34 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Dec 3, 2025

Successfully created backport PR for release-25.11:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Dec 3, 2025
Merged
@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label Dec 3, 2025
@mdaniels5757 mdaniels5757 deleted the mark-broken branch December 3, 2025 13:42
corngood
corngood reviewed Dec 5, 2025
View reviewed changes
pkgs/os-specific/cygwin/w32api/default.nix
};

meta = {
# Marked broken 2025-11-28 because it has failed on Hydra for at least one year.
Copy link
Contributor

@corngood corngood Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This broke eval of everything on cygwin. master already had a fix for this by limiting the platform to cygwin. I'd like to remove the broken flag in #468157.

Copy link
Member Author

@mdaniels5757 mdaniels5757 Dec 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted; looks like 9dd0669 post-dates my PR, which would explain why I missed it :).

@CathalMullan CathalMullan mentioned this pull request Dec 14, 2025
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corngood corngood corngood left review comments

@lukegb lukegb lukegb approved these changes

@happysalada happysalada happysalada approved these changes

@mmahut mmahut Awaiting requested review from mmahut

@RaghavSood RaghavSood Awaiting requested review from RaghavSood

@aanderse aanderse Awaiting requested review from aanderse

@talyz talyz Awaiting requested review from talyz

@globin globin Awaiting requested review from globin

@Ma27 Ma27 Awaiting requested review from Ma27

@alyssais alyssais Awaiting requested review from alyssais

@dit7ya dit7ya Awaiting requested review from dit7ya

@jojosch jojosch Awaiting requested review from jojosch

@mikroskeem mikroskeem Awaiting requested review from mikroskeem

@sikmir sikmir Awaiting requested review from sikmir

@urandom2 urandom2 Awaiting requested review from urandom2

@yl3dy yl3dy Awaiting requested review from yl3dy

+3 more reviewers

@qbisi qbisi qbisi left review comments

@bryanhonof bryanhonof bryanhonof approved these changes

@qweered qweered qweered approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 3+ This PR was reviewed and approved by three or more persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. backport release-25.11 Backport PR automatically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.