tarball: generate packages.json in nix#451424
Merged
wolfgangwalther merged 3 commits intoNixOS:masterfrom Jan 9, 2026
Merged
Conversation
nixpkgs-ci
bot
added
10.rebuild-linux: 501+
3 tasks
Contributor
|
@jopejoe1 Thanks for looking into this! |
jopejoe1
force-pushed
the
genrate-package-info-in-nix
branch
from
b013dfc to
e75c02e
Compare
nixpkgs-ci
bot
added
the
2.status: merge conflict
jopejoe1
force-pushed
the
genrate-package-info-in-nix
branch
from
e75c02e to
afb8b78
Compare
nixpkgs-ci
bot
added
10.rebuild-darwin: 0
jopejoe1
force-pushed
the
genrate-package-info-in-nix
branch
from
afb8b78 to
539fac6
Compare
13 tasks
nixpkgs-ci
bot
added
the
2.status: merge conflict
Member
|
Yes thank for this. |
jopejoe1
force-pushed
the
genrate-package-info-in-nix
branch
from
539fac6 to
c6e7a97
Compare
Member
Author
|
Did a rebase and fixed a new eval failure in #478128 that got added since the last rebase. |
Contributor
|
Wow, didn't watch this for a few weeks; the code has gotten pretty slim :) |
wolfgangwalther
approved these changes
Jan 9, 2026
Contributor
wolfgangwalther
left a comment
wolfgangwalther
left a comment
There was a problem hiding this comment.
I looked at the before/after diff again and now I only see two kinds of differences (although I did not check the full diff, it's huge):
- pname and version are split correctly
- some "new" packages appear, where they have multiple attr paths now ("aliases", but not behind allowAliases). For example
zulu21now appears, which is the same aszulu. The previousnix-envcall would have filtered out those duplicates.
The first one was the goal of this PR, I believe. To be clear: I consider the second one an improvement, because it was often unpredictable and confusing which attribute showed up and which didn't.
LGTM; but we should wait for the other PR, which contains the first commit, to merge first.
nixpkgs-ci
bot
added
the
12.approvals: 1
pname needs to always be evaluable so that our package index can be correctly generatedw
Instead of using nix-env, let's generate directly in Nix. This fixes the issue that version and pname contain the wrong information, as nix-env generates those by splitting name into version and pname instead of directly using those to attrs. This would work towards fixing the following issues: NixOS/nixos-search#770 repology/repology-updater#854
jopejoe1
force-pushed
the
genrate-package-info-in-nix
branch
from
53b6840 to
e6fd126
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to invalid changes in the merge commit
3 tasks
Member
Author
|
Looks like this broke the parsing of repology (repology/repology-updater#1565) as they expect |
Contributor
The |
Contributor
|
Does it make sense to implement a workaround for |
Member
Author
Contributor
|
Can you give a ilst of packages or script to get them? I'll try to fix it |
Member
Author
Currently not on my pc, but i pretty much toke the json file genrated by |
Contributor
Can't we just revert this PR? |
Contributor
|
I don't think a temporary fallback for pname is hard to do, I am looking into it right away. |
2 tasks
Member
Author
|
@qweered here is the list of packages missing Packages missing `pname` |
Contributor
|
Nice thanks; is that something I can produce locally as well? |
Member
Author
Yes, but you need to revert e19bb69, so that my script works. Then you just need to run import json
with open('packages.json', 'r') as file:
data = json.load(file)
packages = data['packages']
for name ,package in packages.items():
if "pname" not in package.keys():
print(name) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of using nix-env, let's generate directly in Nix. This fixes the issue that version and pname contain the wrong information, as nix-env generates those by splitting name into version and pname instead of directly using those to attrs.
This would work towards fixing the following issues:
NixOS/nixos-search#770
repology/repology-updater#854
Note this depends on and includes changes from the following PRs, and only the last commit is for the changes in this PR:
#451244#451417#406555#455366#456539#478128Also currently depends on either #453291 or #453322 to fix the evaling broken in #421125Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.