postgresql{16,17}Packages.age: 1.5.0-rc0 -> 1.6.0-rc0#451417
postgresql{16,17}Packages.age: 1.5.0-rc0 -> 1.6.0-rc0#451417wolfgangwalther merged 3 commits intoNixOS:masterfrom
Conversation
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
jopejoe1
force-pushed
the
postgresPackages.age-update
branch
from
1635403 to
fa876ac
Compare
Ma27
left a comment
Ma27
left a comment
There was a problem hiding this comment.
makes still possible to eval the drv just not possible to build
I'd argue that catching obvious errors is a feature, not a bug.
That being said, in this specific case you can even catch the error with builtins.tryEval.
|
I want throws to fail for what I'm implementing and thus can't really make use of The correct approach would probably be to not even expose this package in Also, the |
Fair. |
In cases where src was a throw, meta failed to eval fixing this by not referencing src in meta.
jopejoe1
force-pushed
the
postgresPackages.age-update
branch
from
fa876ac to
01238f3
Compare
wolfgangwalther
left a comment
wolfgangwalther
left a comment
There was a problem hiding this comment.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 451417
Commit: 01238f33ac76d13e8b45fce3f995886c478de395
x86_64-linux
✅ 2 packages built:
- postgresql16Packages.age
- postgresqlPackages.age (postgresql17Packages.age)
aarch64-linux
✅ 2 packages built:
- postgresql16Packages.age
- postgresqlPackages.age (postgresql17Packages.age)
x86_64-darwin
✅ 2 packages built:
- postgresql16Packages.age
- postgresqlPackages.age (postgresql17Packages.age)
aarch64-darwin
✅ 2 packages built:
- postgresql16Packages.age
- postgresqlPackages.age (postgresql17Packages.age)
wolfgangwalther
dismissed
Ma27’s stale review
I believe these concerns had been addressed by removing the hash = null stuff.
3 participants
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.