Skip to content

schroot: fix build with cmake 4#451412

Merged
jopejoe1 merged 1 commit intoNixOS:masterfrom
bjsowa:fix/schroot
Oct 14, 2025
Merged

schroot: fix build with cmake 4#451412
jopejoe1 merged 1 commit intoNixOS:masterfrom
bjsowa:fix/schroot

Conversation

@bjsowa
Copy link
Member

@bjsowa bjsowa commented Oct 12, 2025 •
edited
Loading

#445447

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 12, 2025
@Sigmanificient Sigmanificient mentioned this pull request Oct 12, 2025
Open
@uninsane
Copy link
Contributor

uninsane commented Oct 12, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 451412
Commit: a0540c39fff73fba0a52630a35217dc4dbca9dd8

x86_64-linux

✅ 2 packages built:
  • nixpkgs-manual
  • schroot

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 12, 2025
@jopejoe1 jopejoe1 added this pull request to the merge queue Oct 14, 2025
Merged via the queue into NixOS:master with commit d424a26 Oct 14, 2025
36 of 38 checks passed
@bjsowa bjsowa deleted the fix/schroot branch October 14, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@uninsane uninsane uninsane approved these changes

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bjsowa @uninsane @jopejoe1