Skip to content

glslviewer: fix build with cmake 4#451394

Merged
yayayayaka merged 1 commit intoNixOS:masterfrom
leiserfg:glslviewer-cmake4
Oct 15, 2025
Merged

glslviewer: fix build with cmake 4#451394
yayayayaka merged 1 commit intoNixOS:masterfrom
leiserfg:glslviewer-cmake4

Conversation

@leiserfg
Copy link
Contributor

@leiserfg leiserfg commented Oct 12, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@leiserfg
Copy link
Contributor Author

leiserfg commented Oct 12, 2025

#445447 (comment)

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 12, 2025
@nix-owners nix-owners bot requested a review from Hodapp87 October 12, 2025 16:49
@nixpkgs-ci nixpkgs-ci bot added 9.needs: reviewer This PR currently has no reviewers requested and needs attention. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 12, 2025
@Sigmanificient Sigmanificient mentioned this pull request Oct 12, 2025
Open
LordGrimmauld
LordGrimmauld approved these changes Oct 14, 2025
View reviewed changes
Copy link
Contributor

@LordGrimmauld LordGrimmauld left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tbh i'd prefer a bump to -unstable. Seeing as submodules are involved, i will accept the cmake flag for this though (as i said in the tracking issue where you asked me about this).

Tested this builds and runs on x86_64-linux

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 14, 2025
@leiserfg
Copy link
Contributor Author

leiserfg commented Oct 14, 2025 •
edited
Loading

I already submitted PRs to upstream, but I'm still waiting for them to be accepted, after that I will bump it in another PR.

@yayayayaka
Copy link
Member

yayayayaka commented Oct 15, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 451394
Commit: 101d3d6966858333baea7c5c255a4eaa2c16d2a5

x86_64-linux

✅ 1 package built:
  • glslviewer

yayayayaka
yayayayaka approved these changes Oct 15, 2025
View reviewed changes
Copy link
Member

@yayayayaka yayayayaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also agree that using a cmake flag is justified in this case.

@yayayayaka yayayayaka added this pull request to the merge queue Oct 15, 2025
Merged via the queue into NixOS:master with commit 917fce3 Oct 15, 2025
34 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LordGrimmauld LordGrimmauld LordGrimmauld approved these changes

@yayayayaka yayayayaka yayayayaka approved these changes

@Hodapp87 Hodapp87 Awaiting requested review from Hodapp87

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@leiserfg @yayayayaka @LordGrimmauld