libresprite: fix build with cmake 4#451388
Conversation
leiserfg
force-pushed
the
push-skmqmmqmknuk
branch
from
9bac2d2 to
00c4e67
Compare
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
|
|
||
| patches = [ | ||
| (fetchpatch2 { | ||
| url = "https://github.com/LibreSprite/LibreSprite/commit/dfaf4d83369f3f978d9dae838cf5ff16178f4ff6.diff"; |
There was a problem hiding this comment.
Patches referencing open PRs should be vendored, see https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#vendoring-patches
There was a problem hiding this comment.
Sorry but it's not what is been advised in #445447 (comment)
also not this is does not:
- solves problems unique to packaging in Nixpkgs
- cannot be fetched easily
- has a high chance to disappear in the future due to unstable or unreliable URLs
So I don't understand why it needs to be vendored to be honest.
There was a problem hiding this comment.
See the paragraph above the Vendoring patches heading:
When adding patches in this manner you should be reasonably sure that the used URL is stable. Patches referencing open pull requests will change when the PR is updated and code forges (such as GitHub) usually garbage collect commits that are no longer reachable due to rebases/amends.
leiserfg
force-pushed
the
push-skmqmmqmknuk
branch
from
00c4e67 to
a6c5e2f
Compare
nixpkgs-ci
bot
added
the
12.approvals: 1
|
yayayayaka
left a comment
yayayayaka
left a comment
There was a problem hiding this comment.
Approved automatically following the successful run of nixpkgs-review.
3 participants
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.