Skip to content

opengothic: fix build with cmake4#451382

Merged
azahi merged 1 commit intoNixOS:masterfrom
azahi:opengothic-cmake
Oct 13, 2025
Merged

opengothic: fix build with cmake4#451382
azahi merged 1 commit intoNixOS:masterfrom
azahi:opengothic-cmake

Conversation

@azahi
Copy link
Member

@azahi azahi commented Oct 12, 2025

Upstream needs to bump submodules. Adding a flag now, assuming a new release will have the fix included.

Related to #445447

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 12, 2025
@Sigmanificient
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 451382
Commit: 679cb08da2f33b4c196551d89f7e2d816dee6382 (subsequent changes)
Merge: 6660c69891353c502647128d73102fcb600b5e47

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/18448708768


x86_64-linux

✅ 2 packages built:
  • opengothic
  • opengothic.dev

aarch64-linux

✅ 2 packages built:
  • opengothic
  • opengothic.dev

@azahi azahi added this pull request to the merge queue Oct 13, 2025
Merged via the queue into NixOS:master with commit 211e37b Oct 13, 2025
34 of 37 checks passed
@azahi azahi deleted the opengothic-cmake branch October 13, 2025 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

9.needs: reviewer This PR currently has no reviewers requested and needs attention. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants