Skip to content

lpcnet: fix build with cmake 4#451378

Merged
doronbehar merged 1 commit intoNixOS:masterfrom
wegank:lpcnet-fix
Oct 14, 2025
Merged

lpcnet: fix build with cmake 4#451378
doronbehar merged 1 commit intoNixOS:masterfrom
wegank:lpcnet-fix

Conversation

@wegank
Copy link
Member

@wegank wegank commented Oct 12, 2025 •
edited by Sigmanificient
Loading

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Oct 12, 2025
@nix-owners nix-owners bot requested review from doronbehar and illdefined October 12, 2025 15:40
@Sigmanificient Sigmanificient mentioned this pull request Oct 12, 2025
Open
@wegank
Copy link
Member Author

wegank commented Oct 12, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 451378
Commit: c41d36b5b5e898c89d7cfeb4c373f57e3bbaf12b

x86_64-linux

✅ 2 packages built:
  • freedv
  • lpcnet

@doronbehar
Copy link
Contributor

doronbehar commented Oct 14, 2025

Thanks!

@doronbehar doronbehar added this pull request to the merge queue Oct 14, 2025
Merged via the queue into NixOS:master with commit fc6b6e3 Oct 14, 2025
34 of 36 checks passed
@wegank wegank deleted the lpcnet-fix branch October 14, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@doronbehar doronbehar Awaiting requested review from doronbehar

@illdefined illdefined Awaiting requested review from illdefined

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wegank @doronbehar