Skip to content

simbaplusplus: fix build with cmake4#451377

Merged
leona-ya merged 1 commit intoNixOS:masterfrom
Sigmanificient:simbaplusplus-cmake-fix
Oct 14, 2025
Merged

simbaplusplus: fix build with cmake4#451377
leona-ya merged 1 commit intoNixOS:masterfrom
Sigmanificient:simbaplusplus-cmake-fix

Conversation

@Sigmanificient
Copy link
Member

@Sigmanificient Sigmanificient commented Oct 12, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 12, 2025
@nix-owners nix-owners bot requested a review from emilytrau October 12, 2025 15:39
@nixpkgs-ci nixpkgs-ci bot added 9.needs: reviewer This PR currently has no reviewers requested and needs attention. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 12, 2025
@Sigmanificient Sigmanificient mentioned this pull request Oct 12, 2025
Open
@Sigmanificient
Copy link
Member Author

Sigmanificient commented Oct 12, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 451377
Commit: 2d57c36330104645e66bb1c64d6640421000096f (subsequent changes)
Merge: 36b3f871142937efd50f38a8198ab4727ede905f

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/18448709600

x86_64-linux

✅ 1 package built:
  • simbaplusplus

aarch64-linux

✅ 1 package built:
  • simbaplusplus

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • simbaplusplus

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • simbaplusplus

@leona-ya leona-ya added this pull request to the merge queue Oct 14, 2025
Merged via the queue into NixOS:master with commit dbf2ef5 Oct 14, 2025
34 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leona-ya leona-ya leona-ya approved these changes

@emilytrau emilytrau Awaiting requested review from emilytrau

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Sigmanificient @leona-ya