Skip to content

surgescript: fix build with cmake4#451373

Merged
leona-ya merged 1 commit intoNixOS:masterfrom
Sigmanificient:surgescript-cmake-fix
Oct 14, 2025
Merged

surgescript: fix build with cmake4#451373
leona-ya merged 1 commit intoNixOS:masterfrom
Sigmanificient:surgescript-cmake-fix

Conversation

@Sigmanificient
Copy link
Member

@Sigmanificient Sigmanificient commented Oct 12, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 12, 2025
@Sigmanificient Sigmanificient mentioned this pull request Oct 12, 2025
Open
@Sigmanificient
Copy link
Member Author

Sigmanificient commented Oct 12, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 451373
Commit: 601aeb9233c07e13b13ba2db5dbcb0cdb4d4e5a6 (subsequent changes)
Merge: e52e885d3863f821647ced0c5448fd3fcb704ae4

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/18448710081

x86_64-linux

❌ 1 package failed to build:
  • opensurge
✅ 1 package built:
  • surgescript
Error logs: `x86_64-linux`
opensurge 
unpacking source archive /nix/store/9j4cisiv9kj39brwhl7x3yjnsyinb7zz-source
source root is source
Running phase: patchPhase
@nix { "action": "setPhase", "phase": "patchPhase" }
Running phase: updateAutotoolsGnuConfigScriptsPhase
@nix { "action": "setPhase", "phase": "updateAutotoolsGnuConfigScriptsPhase" }
Running phase: configurePhase
@nix { "action": "setPhase", "phase": "configurePhase" }
cmake flags: -GNinja -DCMAKE_FIND_USE_SYSTEM_PACKAGE_REGISTRY=OFF -DCMAKE_FIND_USE_PACKAGE_REGISTRY=OFF -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON -DCMAKE_BUILD_TYPE=Release -DBUILD_TESTING=OFF -DCMAKE_INSTALL_LOCALEDIR=/nix/store/zrnbrb5pfrzcspwigvhlb5crg0d3i220-opensurge-0.6.1.2/share/locale -DCMAKE_INSTALL_LIBEXECDIR=/nix/store/zrnbrb5pfrzcspwigvhlb5crg0d3i220-opensurge-0.6.1.2/libexec -DCMAKE_INSTALL_LIBDIR=/nix/store/zrnbrb5pfrzcspwigvhlb5crg0d3i220-opensurge-0.6.1.2/lib -DCMAKE_INSTALL_DOCDIR=/nix/store/zrnbrb5pfrzcspwigvhlb5crg0d3i220-opensurge-0.6.1.2/share/doc/opensurge -DCMAKE_INSTALL_INFODIR=/nix/store/zrnbrb5pfrzcspwigvhlb5crg0d3i220-opensurge-0.6.1.2/share/info -DCMAKE_INSTALL_MANDIR=/nix/store/zrnbrb5pfrzcspwigvhlb5crg0d3i220-opensurge-0.6.1.2/share/man -DCMAKE_INSTALL_INCLUDEDIR=/nix/store/zrnbrb5pfrzcspwigvhlb5crg0d3i220-opensurge-0.6.1.2/include -DCMAKE_INSTALL_SBINDIR=/nix/store/zrnbrb5pfrzcspwigvhlb5crg0d3i220-opensurge-0.6.1.2/sbin -DCMAKE_INSTALL_BINDIR=/nix/store/zrnbrb5pfrzcspwigvhlb5crg0d3i220-opensurge-0.6.1.2/bin -DCMAKE_INSTALL_NAME_DIR=/nix/store/zrnbrb5pfrzcspwigvhlb5crg0d3i220-opensurge-0.6.1.2/lib -DCMAKE_POLICY_DEFAULT_CMP0025=NEW -DCMAKE_FIND_FRAMEWORK=LAST -DCMAKE_STRIP=/nix/store/dmypp1h4ldn0vfk3fi6yfyf5yxp9yz0k-gcc-wrapper-14.3.0/bin/strip -DCMAKE_RANLIB=/nix/store/dmypp1h4ldn0vfk3fi6yfyf5yxp9yz0k-gcc-wrapper-14.3.0/bin/ranlib -DCMAKE_AR=/nix/store/dmypp1h4ldn0vfk3fi6yfyf5yxp9yz0k-gcc-wrapper-14.3.0/bin/ar -DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++ -DCMAKE_INSTALL_PREFIX=/nix/store/zrnbrb5pfrzcspwigvhlb5crg0d3i220-opensurge-0.6.1.2 -DGAME_BINDIR=/nix/store/zrnbrb5pfrzcspwigvhlb5crg0d3i220-opensurge-0.6.1.2/bin -DDESKTOP_ICON_PATH=/nix/store/zrnbrb5pfrzcspwigvhlb5crg0d3i220-opensurge-0.6.1.2/share/pixmaps -DDESKTOP_METAINFO_PATH=/nix/store/zrnbrb5pfrzcspwigvhlb5crg0d3i220-opensurge-0.6.1.2/share/metainfo -DDESKTOP_ENTRY_PATH=/nix/store/zrnbrb5pfrzcspwigvhlb5crg0d3i220-opensurge-0.6.1.2/share/applications -DWANT_BUILD_DATE=OFF
CMake Error at CMakeLists.txt:26 (CMAKE_MINIMUM_REQUIRED):
  Compatibility with CMake < 3.5 has been removed from CMake.

Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax

to tell CMake that the project requires at least <min> but has been updated

to work with policies introduced by <max> or earlier.


Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.


-- Configuring incomplete, errors occurred!

aarch64-linux

❌ 1 package failed to build:
  • opensurge
✅ 1 package built:
  • surgescript
Error logs: `aarch64-linux`
opensurge 
unpacking source archive /nix/store/9j4cisiv9kj39brwhl7x3yjnsyinb7zz-source
source root is source
Running phase: patchPhase
@nix { "action": "setPhase", "phase": "patchPhase" }
Running phase: updateAutotoolsGnuConfigScriptsPhase
@nix { "action": "setPhase", "phase": "updateAutotoolsGnuConfigScriptsPhase" }
Running phase: configurePhase
@nix { "action": "setPhase", "phase": "configurePhase" }
cmake flags: -GNinja -DCMAKE_FIND_USE_SYSTEM_PACKAGE_REGISTRY=OFF -DCMAKE_FIND_USE_PACKAGE_REGISTRY=OFF -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON -DCMAKE_BUILD_TYPE=Release -DBUILD_TESTING=OFF -DCMAKE_INSTALL_LOCALEDIR=/nix/store/1bcb6p3k2a6f2chhrw4cdynqg3y3qdfm-opensurge-0.6.1.2/share/locale -DCMAKE_INSTALL_LIBEXECDIR=/nix/store/1bcb6p3k2a6f2chhrw4cdynqg3y3qdfm-opensurge-0.6.1.2/libexec -DCMAKE_INSTALL_LIBDIR=/nix/store/1bcb6p3k2a6f2chhrw4cdynqg3y3qdfm-opensurge-0.6.1.2/lib -DCMAKE_INSTALL_DOCDIR=/nix/store/1bcb6p3k2a6f2chhrw4cdynqg3y3qdfm-opensurge-0.6.1.2/share/doc/opensurge -DCMAKE_INSTALL_INFODIR=/nix/store/1bcb6p3k2a6f2chhrw4cdynqg3y3qdfm-opensurge-0.6.1.2/share/info -DCMAKE_INSTALL_MANDIR=/nix/store/1bcb6p3k2a6f2chhrw4cdynqg3y3qdfm-opensurge-0.6.1.2/share/man -DCMAKE_INSTALL_INCLUDEDIR=/nix/store/1bcb6p3k2a6f2chhrw4cdynqg3y3qdfm-opensurge-0.6.1.2/include -DCMAKE_INSTALL_SBINDIR=/nix/store/1bcb6p3k2a6f2chhrw4cdynqg3y3qdfm-opensurge-0.6.1.2/sbin -DCMAKE_INSTALL_BINDIR=/nix/store/1bcb6p3k2a6f2chhrw4cdynqg3y3qdfm-opensurge-0.6.1.2/bin -DCMAKE_INSTALL_NAME_DIR=/nix/store/1bcb6p3k2a6f2chhrw4cdynqg3y3qdfm-opensurge-0.6.1.2/lib -DCMAKE_POLICY_DEFAULT_CMP0025=NEW -DCMAKE_FIND_FRAMEWORK=LAST -DCMAKE_STRIP=/nix/store/frxwlync78r3l94863r2cbnz7ngy273j-gcc-wrapper-14.3.0/bin/strip -DCMAKE_RANLIB=/nix/store/frxwlync78r3l94863r2cbnz7ngy273j-gcc-wrapper-14.3.0/bin/ranlib -DCMAKE_AR=/nix/store/frxwlync78r3l94863r2cbnz7ngy273j-gcc-wrapper-14.3.0/bin/ar -DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++ -DCMAKE_INSTALL_PREFIX=/nix/store/1bcb6p3k2a6f2chhrw4cdynqg3y3qdfm-opensurge-0.6.1.2 -DGAME_BINDIR=/nix/store/1bcb6p3k2a6f2chhrw4cdynqg3y3qdfm-opensurge-0.6.1.2/bin -DDESKTOP_ICON_PATH=/nix/store/1bcb6p3k2a6f2chhrw4cdynqg3y3qdfm-opensurge-0.6.1.2/share/pixmaps -DDESKTOP_METAINFO_PATH=/nix/store/1bcb6p3k2a6f2chhrw4cdynqg3y3qdfm-opensurge-0.6.1.2/share/metainfo -DDESKTOP_ENTRY_PATH=/nix/store/1bcb6p3k2a6f2chhrw4cdynqg3y3qdfm-opensurge-0.6.1.2/share/applications -DWANT_BUILD_DATE=OFF
CMake Error at CMakeLists.txt:26 (CMAKE_MINIMUM_REQUIRED):
  Compatibility with CMake < 3.5 has been removed from CMake.

Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax

to tell CMake that the project requires at least <min> but has been updated

to work with policies introduced by <max> or earlier.


Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.


-- Configuring incomplete, errors occurred!

x86_64-darwin (sandbox = true)

❌ 1 package failed to build:
  • opensurge
✅ 1 package built:
  • surgescript
Error logs: `x86_64-darwin`
opensurge 
Running phase: unpackPhase
@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking source archive /nix/store/9j4cisiv9kj39brwhl7x3yjnsyinb7zz-source
source root is source
Running phase: patchPhase
@nix { "action": "setPhase", "phase": "patchPhase" }
Running phase: configurePhase
@nix { "action": "setPhase", "phase": "configurePhase" }
cmake flags: -GNinja -DCMAKE_FIND_USE_SYSTEM_PACKAGE_REGISTRY=OFF -DCMAKE_FIND_USE_PACKAGE_REGISTRY=OFF -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON -DCMAKE_BUILD_TYPE=Release -DBUILD_TESTING=OFF -DCMAKE_INSTALL_LOCALEDIR=/nix/store/7bc0smvlmh8hdblilh388521rwxkbm6j-opensurge-0.6.1.2/share/locale -DCMAKE_INSTALL_LIBEXECDIR=/nix/store/7bc0smvlmh8hdblilh388521rwxkbm6j-opensurge-0.6.1.2/libexec -DCMAKE_INSTALL_LIBDIR=/nix/store/7bc0smvlmh8hdblilh388521rwxkbm6j-opensurge-0.6.1.2/lib -DCMAKE_INSTALL_DOCDIR=/nix/store/7bc0smvlmh8hdblilh388521rwxkbm6j-opensurge-0.6.1.2/share/doc/opensurge -DCMAKE_INSTALL_INFODIR=/nix/store/7bc0smvlmh8hdblilh388521rwxkbm6j-opensurge-0.6.1.2/share/info -DCMAKE_INSTALL_MANDIR=/nix/store/7bc0smvlmh8hdblilh388521rwxkbm6j-opensurge-0.6.1.2/share/man -DCMAKE_INSTALL_INCLUDEDIR=/nix/store/7bc0smvlmh8hdblilh388521rwxkbm6j-opensurge-0.6.1.2/include -DCMAKE_INSTALL_SBINDIR=/nix/store/7bc0smvlmh8hdblilh388521rwxkbm6j-opensurge-0.6.1.2/sbin -DCMAKE_INSTALL_BINDIR=/nix/store/7bc0smvlmh8hdblilh388521rwxkbm6j-opensurge-0.6.1.2/bin -DCMAKE_INSTALL_NAME_DIR=/nix/store/7bc0smvlmh8hdblilh388521rwxkbm6j-opensurge-0.6.1.2/lib -DCMAKE_POLICY_DEFAULT_CMP0025=NEW -DCMAKE_FIND_FRAMEWORK=LAST -DCMAKE_STRIP=/nix/store/lm587kamzj0dkk3118i5gncn2jwl4rab-clang-wrapper-21.1.1/bin/strip -DCMAKE_RANLIB=/nix/store/lm587kamzj0dkk3118i5gncn2jwl4rab-clang-wrapper-21.1.1/bin/ranlib -DCMAKE_AR=/nix/store/lm587kamzj0dkk3118i5gncn2jwl4rab-clang-wrapper-21.1.1/bin/ar -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_INSTALL_PREFIX=/nix/store/7bc0smvlmh8hdblilh388521rwxkbm6j-opensurge-0.6.1.2 -DGAME_BINDIR=/nix/store/7bc0smvlmh8hdblilh388521rwxkbm6j-opensurge-0.6.1.2/bin -DDESKTOP_ICON_PATH=/nix/store/7bc0smvlmh8hdblilh388521rwxkbm6j-opensurge-0.6.1.2/share/pixmaps -DDESKTOP_METAINFO_PATH=/nix/store/7bc0smvlmh8hdblilh388521rwxkbm6j-opensurge-0.6.1.2/share/metainfo -DDESKTOP_ENTRY_PATH=/nix/store/7bc0smvlmh8hdblilh388521rwxkbm6j-opensurge-0.6.1.2/share/applications -DWANT_BUILD_DATE=OFF
CMake Error at CMakeLists.txt:26 (CMAKE_MINIMUM_REQUIRED):
  Compatibility with CMake < 3.5 has been removed from CMake.

Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax

to tell CMake that the project requires at least <min> but has been updated

to work with policies introduced by <max> or earlier.


Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.


-- Configuring incomplete, errors occurred!

aarch64-darwin (sandbox = true)

❌ 1 package failed to build:
  • opensurge
✅ 1 package built:
  • surgescript
Error logs: `aarch64-darwin`
opensurge 
unpacking source archive /nix/store/9j4cisiv9kj39brwhl7x3yjnsyinb7zz-source
source root is source
Running phase: patchPhase
@nix { "action": "setPhase", "phase": "patchPhase" }
Running phase: updateAutotoolsGnuConfigScriptsPhase
@nix { "action": "setPhase", "phase": "updateAutotoolsGnuConfigScriptsPhase" }
Running phase: configurePhase
@nix { "action": "setPhase", "phase": "configurePhase" }
cmake flags: -GNinja -DCMAKE_FIND_USE_SYSTEM_PACKAGE_REGISTRY=OFF -DCMAKE_FIND_USE_PACKAGE_REGISTRY=OFF -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON -DCMAKE_BUILD_TYPE=Release -DBUILD_TESTING=OFF -DCMAKE_INSTALL_LOCALEDIR=/nix/store/gi527c1isfj0lbh5fy50yrfppldwkcs0-opensurge-0.6.1.2/share/locale -DCMAKE_INSTALL_LIBEXECDIR=/nix/store/gi527c1isfj0lbh5fy50yrfppldwkcs0-opensurge-0.6.1.2/libexec -DCMAKE_INSTALL_LIBDIR=/nix/store/gi527c1isfj0lbh5fy50yrfppldwkcs0-opensurge-0.6.1.2/lib -DCMAKE_INSTALL_DOCDIR=/nix/store/gi527c1isfj0lbh5fy50yrfppldwkcs0-opensurge-0.6.1.2/share/doc/opensurge -DCMAKE_INSTALL_INFODIR=/nix/store/gi527c1isfj0lbh5fy50yrfppldwkcs0-opensurge-0.6.1.2/share/info -DCMAKE_INSTALL_MANDIR=/nix/store/gi527c1isfj0lbh5fy50yrfppldwkcs0-opensurge-0.6.1.2/share/man -DCMAKE_INSTALL_INCLUDEDIR=/nix/store/gi527c1isfj0lbh5fy50yrfppldwkcs0-opensurge-0.6.1.2/include -DCMAKE_INSTALL_SBINDIR=/nix/store/gi527c1isfj0lbh5fy50yrfppldwkcs0-opensurge-0.6.1.2/sbin -DCMAKE_INSTALL_BINDIR=/nix/store/gi527c1isfj0lbh5fy50yrfppldwkcs0-opensurge-0.6.1.2/bin -DCMAKE_INSTALL_NAME_DIR=/nix/store/gi527c1isfj0lbh5fy50yrfppldwkcs0-opensurge-0.6.1.2/lib -DCMAKE_POLICY_DEFAULT_CMP0025=NEW -DCMAKE_FIND_FRAMEWORK=LAST -DCMAKE_STRIP=/nix/store/l58v977vq4qy58m1bw60bzrpkywizz2b-clang-wrapper-21.1.1/bin/strip -DCMAKE_RANLIB=/nix/store/l58v977vq4qy58m1bw60bzrpkywizz2b-clang-wrapper-21.1.1/bin/ranlib -DCMAKE_AR=/nix/store/l58v977vq4qy58m1bw60bzrpkywizz2b-clang-wrapper-21.1.1/bin/ar -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_INSTALL_PREFIX=/nix/store/gi527c1isfj0lbh5fy50yrfppldwkcs0-opensurge-0.6.1.2 -DGAME_BINDIR=/nix/store/gi527c1isfj0lbh5fy50yrfppldwkcs0-opensurge-0.6.1.2/bin -DDESKTOP_ICON_PATH=/nix/store/gi527c1isfj0lbh5fy50yrfppldwkcs0-opensurge-0.6.1.2/share/pixmaps -DDESKTOP_METAINFO_PATH=/nix/store/gi527c1isfj0lbh5fy50yrfppldwkcs0-opensurge-0.6.1.2/share/metainfo -DDESKTOP_ENTRY_PATH=/nix/store/gi527c1isfj0lbh5fy50yrfppldwkcs0-opensurge-0.6.1.2/share/applications -DWANT_BUILD_DATE=OFF
CMake Error at CMakeLists.txt:26 (CMAKE_MINIMUM_REQUIRED):
  Compatibility with CMake < 3.5 has been removed from CMake.

Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax

to tell CMake that the project requires at least <min> but has been updated

to work with policies introduced by <max> or earlier.


Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.


-- Configuring incomplete, errors occurred!

@leona-ya leona-ya added this pull request to the merge queue Oct 14, 2025
Merged via the queue into NixOS:master with commit d07be78 Oct 14, 2025
32 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leona-ya leona-ya leona-ya approved these changes

Assignees

No one assigned

Labels

9.needs: reviewer This PR currently has no reviewers requested and needs attention. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Sigmanificient @leona-ya