Skip to content

nixos/systemd/shutdown: make bashless#451355

Merged
nikstur merged 3 commits intoNixOS:staging-nixosfrom
nikstur:shutdownramfs-bashless
Oct 14, 2025
Merged

nixos/systemd/shutdown: make bashless#451355
nikstur merged 3 commits intoNixOS:staging-nixosfrom
nikstur:shutdownramfs-bashless

Conversation

@nikstur
Copy link
Contributor

@nikstur nikstur commented Oct 12, 2025 •
edited
Loading

  • Re-enable systemd-timesyncd in the bashless profile since it's bashless now
  • Add more sandboxing options to generate-shutdown-ramfs
  • Make shutdown ramfs bashless and re-enable it in the bashless profile

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nikstur nikstur mentioned this pull request Oct 12, 2025
Closed
@nikstur nikstur changed the title Shutdownramfs bashless nixos/systemd/shutdown: make bashless Oct 12, 2025
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-nixos-tests This PR causes rebuilds for all NixOS tests and should normally target the staging branches. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: systemd Software suite that provides an array of system components for Linux operating systems. labels Oct 12, 2025
@nikstur nikstur force-pushed the shutdownramfs-bashless branch from c752e9b to 6d022d5 Compare October 12, 2025 14:53
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 13, 2025
@nikstur nikstur marked this pull request as draft October 14, 2025 08:13
@nikstur nikstur force-pushed the shutdownramfs-bashless branch from 6d022d5 to 2eead90 Compare October 14, 2025 08:13
@nikstur nikstur changed the base branch from master to staging-nixos October 14, 2025 08:14
@nixpkgs-ci nixpkgs-ci bot closed this Oct 14, 2025
@nixpkgs-ci nixpkgs-ci bot reopened this Oct 14, 2025
@nikstur nikstur force-pushed the shutdownramfs-bashless branch from 2eead90 to 653fd8c Compare October 14, 2025 08:15
@nikstur nikstur marked this pull request as ready for review October 14, 2025 08:15
@nikstur
Copy link
Contributor Author

nikstur commented Oct 14, 2025

Re-targeted on staging-nixos so @Ma27 is happy.

@nikstur nikstur merged commit f7ecfff into NixOS:staging-nixos Oct 14, 2025
27 checks passed
@Ma27
Copy link
Member

Ma27 commented Oct 14, 2025

Re-targeted on staging-nixos so @Ma27 is happy.

While I'm happy to hear that this is a goal for you, I'd like to add that this is nothing I did for my own entertainment, but build infra people asked me to ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ElvishJerricco ElvishJerricco ElvishJerricco approved these changes

@flokli flokli Awaiting requested review from flokli

@aanderse aanderse Awaiting requested review from aanderse

@LordGrimmauld LordGrimmauld Awaiting requested review from LordGrimmauld

@arianvp arianvp Awaiting requested review from arianvp

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: systemd Software suite that provides an array of system components for Linux operating systems. 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-nixos-tests This PR causes rebuilds for all NixOS tests and should normally target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nikstur @Ma27 @ElvishJerricco