Skip to content

tasksh: add cmakeFlags for CMake >= 3.5#451341

Merged
jopejoe1 merged 1 commit intoNixOS:masterfrom
LudovicoPiero:tasksh-fix
Oct 14, 2025
Merged

tasksh: add cmakeFlags for CMake >= 3.5#451341
jopejoe1 merged 1 commit intoNixOS:masterfrom
LudovicoPiero:tasksh-fix

Conversation

@LudovicoPiero
Copy link
Member

Resolves #451335

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 12, 2025
@nix-owners nix-owners bot requested a review from matthiasbeyer October 12, 2025 13:20
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Oct 12, 2025
@Sigmanificient
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 451341
Commit: f6b4bf1e962cee5532370332a09298ca73bff3bf (subsequent changes)
Merge: 759956e66ef7528ecf350c66e249c77a6160cac8

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/18444712871


x86_64-linux

✅ 1 package built:
  • tasksh

aarch64-linux

✅ 1 package built:
  • tasksh

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • tasksh

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • tasksh

@jopejoe1 jopejoe1 added this pull request to the merge queue Oct 14, 2025
Merged via the queue into NixOS:master with commit fea3647 Oct 14, 2025
35 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failure: tasksh

4 participants