Skip to content

tagainijisho: fix build with cmake 4#451323

Merged
vbgl merged 1 commit intoNixOS:masterfrom
minegameYTB:fix-tagainijisho/cmake-error
Oct 13, 2025
Merged

tagainijisho: fix build with cmake 4#451323
vbgl merged 1 commit intoNixOS:masterfrom
minegameYTB:fix-tagainijisho/cmake-error

Conversation

@minegameYTB
Copy link
Contributor

@minegameYTB minegameYTB commented Oct 12, 2025

Tracking issue #445447 (affect by cmake build failure)

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 12, 2025
@nix-owners nix-owners bot requested a review from vbgl October 12, 2025 12:27
@minegameYTB minegameYTB reopened this Oct 12, 2025
@NixOS NixOS deleted a comment from minegameYTB Oct 12, 2025
@Sigmanificient
Copy link
Member

Sigmanificient commented Oct 12, 2025

@minegameYTB Moved the description back on the description 🙃

@minegameYTB
Copy link
Contributor Author

Thanks ^^ !

@Sigmanificient
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 451323
Commit: e3b332a1ab4c840746d8dcdee46fc4a770048280 (subsequent changes)
Merge: cdda33bbd35354c098244e2e595d3554f24171d3

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/18443979632


x86_64-linux

✅ 1 package built:
  • tagainijisho

aarch64-linux

✅ 1 package built:
  • tagainijisho

x86_64-darwin

No rebuilds


aarch64-darwin

No rebuilds

@vbgl vbgl added this pull request to the merge queue Oct 13, 2025
Merged via the queue into NixOS:master with commit 43fbc6d Oct 13, 2025
61 of 64 checks passed
@minegameYTB minegameYTB deleted the fix-tagainijisho/cmake-error branch October 13, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants