Skip to content

windows: fix eval of some packages on linux#451244

Merged
wolfgangwalther merged 1 commit intoNixOS:masterfrom
jopejoe1:windows-fix-eval
Oct 27, 2025
Merged

windows: fix eval of some packages on linux#451244
wolfgangwalther merged 1 commit intoNixOS:masterfrom
jopejoe1:windows-fix-eval

Conversation

@jopejoe1
Copy link
Member

@jopejoe1 jopejoe1 commented Oct 12, 2025 •
edited
Loading

This makes those packages appear in search, not sure if this is the correct way to fix it.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@jopejoe1
windows: fix eval of some packages on linux
fc2902e 
This makes those packages appear in search
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 6.topic: windows Running, or buiding, packages on Windows 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 12, 2025
@jopejoe1 jopejoe1 mentioned this pull request Oct 12, 2025
Merged
13 tasks
@jopejoe1 jopejoe1 marked this pull request as draft October 19, 2025 00:13
@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Oct 19, 2025
@wolfgangwalther wolfgangwalther requested a review from a team October 23, 2025 11:08
@jopejoe1 jopejoe1 marked this pull request as ready for review October 23, 2025 20:11
@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Oct 23, 2025
@jopejoe1
Copy link
Member Author

jopejoe1 commented Oct 27, 2025

Note: the nativeLibc override would need tobe removed when #456138 is merged.

@wolfgangwalther
Copy link
Contributor

wolfgangwalther commented Oct 27, 2025

This makes those packages appear in search, not sure if this is the correct way to fix it.

After staring at wrapCCWith the last couple of days for quite a while, I believe this is fine to fix eval.

@wolfgangwalther wolfgangwalther added this pull request to the merge queue Oct 27, 2025
Merged via the queue into NixOS:master with commit 9679987 Oct 27, 2025
37 of 38 checks passed
@jopejoe1 jopejoe1 deleted the windows-fix-eval branch October 27, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

6.topic: windows Running, or buiding, packages on Windows 9.needs: reviewer This PR currently has no reviewers requested and needs attention. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jopejoe1 @wolfgangwalther