Skip to content

dynamips: fix build with CMake 4#451121

Merged
Sigmanificient merged 1 commit intoNixOS:masterfrom
dotlambda:dynamips
Oct 12, 2025
Merged

dynamips: fix build with CMake 4#451121
Sigmanificient merged 1 commit intoNixOS:masterfrom
dotlambda:dynamips

Conversation

@dotlambda
Copy link
Member

@dotlambda dotlambda commented Oct 11, 2025

fixes #450938

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@dotlambda dotlambda requested a review from MrSom3body October 11, 2025 20:55
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. labels Oct 11, 2025
@nix-owners nix-owners bot requested a review from anthonyroussel October 11, 2025 21:00
@Sigmanificient
Copy link
Member

Sigmanificient commented Oct 11, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 451121
Commit: c6521a17e339e5c93ca88ce63c62da0ecef865aa (subsequent changes)
Merge: 593eaff7cac70d721bbd01716d6205a93158b554

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/18434650126

x86_64-linux

✅ 1 package built:
  • dynamips

aarch64-linux

✅ 1 package built:
  • dynamips

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • dynamips

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • dynamips

MrSom3body
MrSom3body approved these changes Oct 12, 2025
View reviewed changes
Copy link
Member

@MrSom3body MrSom3body left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@Sigmanificient Sigmanificient added this pull request to the merge queue Oct 12, 2025
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Oct 12, 2025
Merged via the queue into NixOS:master with commit 086ebfb Oct 12, 2025
34 of 37 checks passed
@dotlambda dotlambda deleted the dynamips branch October 12, 2025 13:26
@Sigmanificient Sigmanificient mentioned this pull request Oct 12, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Sigmanificient Sigmanificient Sigmanificient approved these changes

@anthonyroussel anthonyroussel Awaiting requested review from anthonyroussel

+1 more reviewer

@MrSom3body MrSom3body MrSom3body approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Build failure: dynamips

3 participants

@dotlambda @Sigmanificient @MrSom3body