Skip to content

gromit-mpx: fix build on CMake 4.0#451113

Merged
pyrox0 merged 1 commit intoNixOS:masterfrom
amarshall:fix-gromit-mpx
Oct 13, 2025
Merged

gromit-mpx: fix build on CMake 4.0#451113
pyrox0 merged 1 commit intoNixOS:masterfrom
amarshall:fix-gromit-mpx

Conversation

@amarshall
Copy link
Member

@amarshall amarshall commented Oct 11, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@amarshall amarshall marked this pull request as ready for review October 11, 2025 20:27
@nix-owners nix-owners bot requested review from gepbird and pjones October 11, 2025 20:31
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 11, 2025
leona-ya
leona-ya previously requested changes Oct 11, 2025
View reviewed changes
pkgs/by-name/gr/gromit-mpx/package.nix Outdated
patches = [
(fetchpatch2 {
# https://github.com/bk138/gromit-mpx/pull/242
url = "https://github.com/bk138/gromit-mpx/pull/242/commits/793fa6e472c8472e064a75eb328947d68d4efe3e.patch?full_index=1";
Copy link
Member

@leona-ya leona-ya Oct 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please vendor commits from unmerged PRs, as they might still change during review and then GitHub regularly garbage-collects them

Copy link
Member Author

@amarshall amarshall Oct 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch is merged upstream, I have updated to the merged commit.

gepbird
gepbird reviewed Oct 11, 2025
View reviewed changes
Copy link
Contributor

@gepbird gepbird left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, other than avoiding fetching the patch, this looks good.

@gepbird
Copy link
Contributor

gepbird commented Oct 12, 2025

#445447

@Sigmanificient Sigmanificient mentioned this pull request Oct 12, 2025
Open
@gepbird gepbird requested review from gepbird and leona-ya October 13, 2025 04:35
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Oct 13, 2025
@pjones
Copy link
Contributor

pjones commented Oct 13, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 451113
Commit: b663e5c52f4ae4512fa0ababc5fb43ac9f1206c2

x86_64-linux

✅ 1 package built:
  • gromit-mpx

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Oct 13, 2025
@pyrox0 pyrox0 dismissed leona-ya’s stale review October 13, 2025 19:17

Issue that was brought up was solved.

@pyrox0 pyrox0 enabled auto-merge October 13, 2025 19:17
@pyrox0 pyrox0 added this pull request to the merge queue Oct 13, 2025
Merged via the queue into NixOS:master with commit fed1227 Oct 13, 2025
31 of 34 checks passed
gepbird added a commit to tchfoo/raspi-dotfiles that referenced this pull request Oct 17, 2025
@gepbird
flake.lock: Update
a84acbb 
Flake lock file updates:

• Updated input 'gep-dotfiles':
    'github:gepbird/dotfiles/cda5a6f4004ff74661ab1f1bc0fb22e93fd21145' (2025-10-09)
  → 'github:gepbird/dotfiles/f3bdc1ce8bcfe51d02f2f2ed83e4bd71773467b0' (2025-10-12)
• Updated input 'gep-dotfiles/nix-index-database':
    'github:nix-community/nix-index-database/ec7a78cb0e098832d8acac091a4df393259c4839' (2025-09-28)
  → 'github:nix-community/nix-index-database/0ca69684091aa3a6b1fe994c4afeff305b15e915' (2025-10-05)
• Added input 'gep-dotfiles/nixpkgs-patch-gromit-mpx-fix-build':
    'NixOS/nixpkgs#451113'
• Added input 'gep-dotfiles/nixpkgs-patch-qgnomeplatform-fix-build':
    'NixOS/nixpkgs#449396'
• Removed input 'gep-dotfiles/nixpkgs-patch-vm-efi-fix'
• Updated input 'gep-dotfiles/nvim':
    'github:gepbird/nvim/5c844f6516df198ed1562e400503a38d780abf24' (2025-10-02)
  → 'github:gepbird/nvim/6c944752c09f853324c6de4a93ff8309b3dfbb05' (2025-10-11)
• Updated input 'gep-dotfiles/nvim/neovim-nightly':
    'github:nix-community/neovim-nightly-overlay/c208a2bebc96e5bc9db3780ef4d62511ebd83c51' (2025-10-02)
  → 'github:nix-community/neovim-nightly-overlay/d5ef90cf4577df3e3daef7e070d200cca64c889f' (2025-10-11)
• Updated input 'gep-dotfiles/nvim/neovim-nightly/neovim-src':
    'github:neovim/neovim/43f7434bd5fa5d13a3aefe4bfaea2973bae7dda2' (2025-10-01)
  → 'github:neovim/neovim/fafc329bbd1e15f9ab595568e8cd8b10295113dd' (2025-10-10)
• Updated input 'gep-dotfiles/nvim/nixvim':
    'github:nix-community/nixvim/eb54f65d9b24310a55de000e62ff6053aa8874ed' (2025-10-02)
  → 'github:nix-community/nixvim/c66070248254d4efb619c3423d71ab3592b31234' (2025-10-11)
• Updated input 'home-manager':
    'github:nix-community/home-manager/d305eece827a3fe317a2d70138f53feccaf890a1' (2025-10-10)
  → 'github:nix-community/home-manager/722792af097dff5790f1a66d271a47759f477755' (2025-10-17)
• Updated input 'moe':
    'github:ymstnt-com/moe/0927b4a2ef76c9510f33a62c47308064b35b9b2f' (2025-09-16)
  → 'github:ymstnt-com/moe/9a41dd75f746ec6817f9cce84230047fd4008b93' (2025-10-15)
• Updated input 'nixpkgs':
    'github:NixOS/nixpkgs/0b4defa2584313f3b781240b29d61f6f9f7e0df3' (2025-10-09)
  → 'github:NixOS/nixpkgs/544961dfcce86422ba200ed9a0b00dd4b1486ec5' (2025-10-15)
• Updated input 'nixpkgs-patch-rauthy-init':
    'NixOS/nixpkgs#371091'
  → 'NixOS/nixpkgs#371091'
• Updated input 'nur':
    'github:nix-community/NUR/22fdd29f961ea2a82464d618907fd5cdc2d4a457' (2025-10-11)
  → 'github:nix-community/NUR/f0a2d04fc5a1a97773cb1386e1f97865d6d389a2' (2025-10-17)
• Updated input 'ymstnt-dotfiles':
    'github:ymstnt/dotfiles/a44b041fb28fd3724d8bae11f60b32a8b3e12748' (2025-10-12)
  → 'github:ymstnt/dotfiles/4b4d7a6175c18430e447b232224da97437a6f3cd' (2025-10-16)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gepbird gepbird gepbird approved these changes

@leona-ya leona-ya Awaiting requested review from leona-ya

+1 more reviewer

@pjones pjones pjones approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@amarshall @gepbird @pjones @leona-ya @pyrox0