lastools: fix compilation with cmake4#451082
Merged
pyrox0 merged 1 commit intoNixOS:masterfrom Oct 13, 2025
Merged
Conversation
Sigmanificient
previously requested changes
Oct 11, 2025
Comment on lines
+21
to
+22
| # https://github.com/lastools/LAStools/pull/234 | ||
| ./cmake.diff |
Member
There was a problem hiding this comment.
This pull request has been merged 7 month ago, you can directly fetch it from its stable link and using fetchpatch
Contributor
Author
There was a problem hiding this comment.
This patch does not apply cleanly any more, see the description of the pull request.
Contributor
Author
There was a problem hiding this comment.
More accurately, this patch never applied correctly into the released version.
Contributor
Author
|
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
nix-owners
bot
requested review from
StephenWithPH,
imincik,
l0b0,
nh2,
nialov,
sikmir and
willcohen
Philipp-M
approved these changes
Oct 12, 2025
Member
Philipp-M
left a comment
Philipp-M
left a comment
There was a problem hiding this comment.
Thanks for picking this up, LGTM.
nixpkgs-ci
bot
added
the
12.approvals: 1
imincik
approved these changes
Oct 13, 2025
nixpkgs-ci
bot
added
12.approvals: 2
pyrox0
dismissed
Sigmanificient’s stale review
maintainers believe patch is fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
I rebased the upstream patch linked in the patches section. I do hope I did that correctly. It does build and las2txt works. Lasinfo seems to work, but does segfault at the end just as the 25.05 version does ;-)
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.