Skip to content

sd-mux-ctrl: fix for CMake 4#451059

Merged
uninsane merged 1 commit intoNixOS:masterfrom
newAM:sd-mux-ctrl-cmake-4
Oct 13, 2025
Merged

sd-mux-ctrl: fix for CMake 4#451059
uninsane merged 1 commit intoNixOS:masterfrom
newAM:sd-mux-ctrl-cmake-4

Conversation

@newAM
Copy link
Member

@newAM newAM commented Oct 11, 2025

Reference #445447

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@newAM newAM mentioned this pull request Oct 11, 2025
Open
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 11, 2025
@nix-owners nix-owners bot requested a review from sarcasticadmin October 11, 2025 17:11
@nixpkgs-ci nixpkgs-ci bot added 9.needs: reviewer This PR currently has no reviewers requested and needs attention. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 11, 2025
@sarcasticadmin
Copy link
Member

sarcasticadmin commented Oct 11, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 451059
Commit: c16eb0968d7b853e6193502c20ae741f19823370

x86_64-linux

✅ 1 package built:
  • sd-mux-ctrl

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Oct 11, 2025
Sigmanificient
Sigmanificient previously requested changes Oct 11, 2025
View reviewed changes
Copy link
Member

@Sigmanificient Sigmanificient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see if upstream as an update for this, or try to make a patch before simply setting CMAKE_POLICY_VERSION_MINIMUM. Refer to the tracking issue for the step to follow.

@newAM
Copy link
Member Author

newAM commented Oct 11, 2025

Please see if upstream as an update for this, or try to make a patch

The upstream source host is down. I would prefer not to make a patch because the path to upstreaming the patch is broken.

@Sigmanificient
Copy link
Member

Sigmanificient commented Oct 11, 2025

@newAM Since when is the upstream source down? Should we consider replacing it?

@newAM
Copy link
Member Author

newAM commented Oct 11, 2025 •
edited
Loading

I only noticed today when updating this. The host is having SSL problems. I am on firefox mobile and don't get more specific diagnostics. The SSL problem may be as a result of some TLS hardening I have enabled. Edit: or the problem could be with the hotel WiFi doing some wacky MITM.

I was planning to wireshark the connection when I get home (in three weeks) and contacting the hardware vendor if the issue is on their end, they have been responsive to my emails in the past.

@Sigmanificient
Copy link
Member

Sigmanificient commented Oct 11, 2025

@LordGrimmauld Though about this?

@Sigmanificient Sigmanificient dismissed their stale review October 11, 2025 18:23

Unsure what to do, letting Grimmauld handle that one :)

@sarcasticadmin
Copy link
Member

sarcasticadmin commented Oct 11, 2025 •
edited
Loading

Repos still there for me:

git clone https://git.tizen.org/cgit/tools/testlab/sd-mux
Cloning into 'sd-mux'...
Fetching objects: 295, done.

The cgit site seems to be there but my browser keeps trying to force TLS so I havent dug into if thats me or the site's config:

$ curl -L  http://git.tizen.org/
<!DOCTYPE html>
<html lang='en'>
<head>
<title>Tizen Project Staging GIT Repositories</title>
<meta name='generator' content='cgit v1.2.3'/>
<meta name='robots' content='index, nofollow'/>
<link rel='stylesheet' type='text/css' href='/cgit-web/cgit.css'/>
<link rel='shortcut icon' href='/favicon.ico'/>
</head>
<body>
<div id='cgit'><table id='header'>
<tr>
<td class='logo' rowspan='2'><a href='/cgit/'><img src='/cgit-web/tizen-pinwheel.png' alt='cgit logo'/></a></td>
<td class='main'>Tizen Project Staging GIT Repositories</td></tr>
<tr><td class='sub'>a fast webinterface for the git dscm</td></tr></table>
<table class='tabs'><tr><td>
<a class='active' href='/cgit/'>index</a></td><td class='form'><form method='get' action='/cgit/'>
<input type='search' name='q' size='10' value=''/>
<input type='submit' value='search'/>
</form></td></tr></table>
...

@Sigmanificient
Copy link
Member

Sigmanificient commented Oct 11, 2025

I got an SSL_ERROR_RX_UNEXPECTED_NEW_SESSION_TICKET on firefox, but it does seems to work via curl!

@sarcasticadmin
Copy link
Member

sarcasticadmin commented Oct 11, 2025

Opening up https://git.tizen.org/cgit/tools/testlab/sd-mux with firefox (128.11.0esr (64-bit)) in a private browsing window works for me:

ss-202510111760208071

@sarcasticadmin
Copy link
Member

sarcasticadmin commented Oct 11, 2025

No official owner defined for this repo in cgit: https://git.tizen.org/cgit/?q=mux but maybe reaching out to Adam since he was the last one to make changes to sd-mux and is in the repos AUTHORS file

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Oct 12, 2025
@newAM newAM force-pushed the sd-mux-ctrl-cmake-4 branch from c16eb09 to 54c65b6 Compare October 12, 2025 17:38
@newAM
Copy link
Member Author

newAM commented Oct 12, 2025

Thanks everyone for the investigation, I reworked this as a substituteInPlace and I'll work on getting it to the upstream later on.

@uninsane uninsane added this pull request to the merge queue Oct 13, 2025
Merged via the queue into NixOS:master with commit e870f74 Oct 13, 2025
28 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NickCao NickCao NickCao approved these changes

@Sigmanificient Sigmanificient Sigmanificient left review comments

+1 more reviewer

@sarcasticadmin sarcasticadmin sarcasticadmin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@newAM @sarcasticadmin @Sigmanificient @NickCao @uninsane