Skip to content

CuboCore.libcprime: fix against cmake-4#450976

Merged
jopejoe1 merged 1 commit intoNixOS:masterfrom
trofi:CuboCore.libcprime-cmake-4-fix
Oct 14, 2025
Merged

CuboCore.libcprime: fix against cmake-4#450976
jopejoe1 merged 1 commit intoNixOS:masterfrom
trofi:CuboCore.libcprime-cmake-4-fix

Conversation

@trofi
Copy link
Contributor

@trofi trofi commented Oct 11, 2025

Without the change the build fails as https://hydra.nixos.org/build/309809196:

CMake Error at CMakeLists.txt:2 (cmake_minimum_required):
Compatibility with CMake < 3.5 has been removed from CMake.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

Without the change the build fails as https://hydra.nixos.org/build/309809196:

  CMake Error at CMakeLists.txt:2 (cmake_minimum_required):
    Compatibility with CMake < 3.5 has been removed from CMake.
@trofi
Copy link
Contributor Author

trofi commented Oct 11, 2025

Relevant tracker:

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Oct 11, 2025
@trofi
Copy link
Contributor Author

trofi commented Oct 11, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 450976
Commit: 7aa148c41d70a194388b1be06a3c096e3399f11d


x86_64-linux

⏩ 1 package marked as broken and skipped:
  • CuboCore.corestuff
✅ 21 packages built:
  • CuboCore.coreaction
  • CuboCore.corearchiver
  • CuboCore.corefm
  • CuboCore.coregarage
  • CuboCore.corehunt
  • CuboCore.coreimage
  • CuboCore.coreinfo
  • CuboCore.corekeyboard
  • CuboCore.corepad
  • CuboCore.corepaint
  • CuboCore.corepdf
  • CuboCore.corepins
  • CuboCore.corerenamer
  • CuboCore.coreshot
  • CuboCore.corestats
  • CuboCore.coreterminal
  • CuboCore.coretime
  • CuboCore.coretoppings
  • CuboCore.coreuniverse
  • CuboCore.libcprime
  • nixpkgs-manual

@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Oct 11, 2025
@benjumanji benjumanji mentioned this pull request Oct 12, 2025
13 tasks
@jopejoe1 jopejoe1 added this pull request to the merge queue Oct 14, 2025
Merged via the queue into NixOS:master with commit 603d100 Oct 14, 2025
34 of 36 checks passed
@trofi trofi deleted the CuboCore.libcprime-cmake-4-fix branch October 14, 2025 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

9.needs: reviewer This PR currently has no reviewers requested and needs attention. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants