Merged
Conversation
13 tasks
Contributor
Contributor
|
@guitargeek Could you cherry-pick the gfal2 change from PR #450320? |
41b64ad to
bcd4728
Compare
Contributor
Author
|
Sure! I updated this PR. |
Contributor
|
@ofborg build gfal2-util.tests |
khaneliman
reviewed
Oct 13, 2025
bcd4728 to
ced8371
Compare
Contributor
Author
|
@ShamrockLee, the minimum required CMake version is now patched in the gfal2 source directly. |
ShamrockLee
reviewed
Oct 15, 2025
Contributor
ShamrockLee
left a comment
There was a problem hiding this comment.
It would be good to go if davix, davix-copy, gfal2, andgfal2.tests build.
Upgrade davix and include patch for CMake 4 compatability.
ced8371 to
4ae54c3
Compare
Contributor
Author
Yes, I have checked locally that this all works. @ShamrockLee, @khaneliman, can we go ahead with this PR? Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade davix and include patch for CMake 4 compatability.
Alternative to #450320.
@ShamrockLee, FYI