Skip to content

systemd: drop reference to deleted systemd-timesyncd nixos test#450935

Merged
nikstur merged 1 commit intoNixOS:masterfrom
trofi:systemd-fix-test-eval
Oct 11, 2025
Merged

systemd: drop reference to deleted systemd-timesyncd nixos test#450935
nikstur merged 1 commit intoNixOS:masterfrom
trofi:systemd-fix-test-eval

Conversation

@trofi
Copy link
Contributor

@trofi trofi commented Oct 11, 2025

Without the change the eval fails as:

$ nix build --no-link -f. defaultPkgConfigPackages.libsystemd.tests
error:
   … while evaluating the attribute 'systemd-timesyncd'

   … in the condition of the assert statement
     at pkgs/os-specific/linux/systemd/default.nix:1023:11:
     1022|           name: value:
     1023|           assert lib.assertMsg (lib.isDerivation value) "${name} is not a derivation";
         |           ^
     1024|           value

   … in the left operand of the OR (||) operator
     at /home/slyfox/dev/git/nixpkgs-master/lib/asserts.nix:50:31:
       49|   # TODO(Profpatsch): add tests that check stderr
       50|   assertMsg = pred: msg: pred || throw msg;
         |                               ^
       51|

   error: attribute 'systemd-timesyncd' missing
   at pkgs/os-specific/linux/systemd/default.nix:1010:13:
     1009|             systemd-sysusers-password-option-override-ordering
     1010|             systemd-timesyncd
         |             ^
     1011|             systemd-timesyncd-nscd-dnssec

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

Without the change the eval fails as:

    $ nix build --no-link -f. defaultPkgConfigPackages.libsystemd.tests
    error:
       … while evaluating the attribute 'systemd-timesyncd'

       … in the condition of the assert statement
         at pkgs/os-specific/linux/systemd/default.nix:1023:11:
         1022|           name: value:
         1023|           assert lib.assertMsg (lib.isDerivation value) "${name} is not a derivation";
             |           ^
         1024|           value

       … in the left operand of the OR (||) operator
         at /home/slyfox/dev/git/nixpkgs-master/lib/asserts.nix:50:31:
           49|   # TODO(Profpatsch): add tests that check stderr
           50|   assertMsg = pred: msg: pred || throw msg;
             |                               ^
           51|

       error: attribute 'systemd-timesyncd' missing
       at pkgs/os-specific/linux/systemd/default.nix:1010:13:
         1009|             systemd-sysusers-password-option-override-ordering
         1010|             systemd-timesyncd
             |             ^
         1011|             systemd-timesyncd-nscd-dnssec
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 6.topic: systemd Software suite that provides an array of system components for Linux operating systems. labels Oct 11, 2025
@nikstur
Copy link
Contributor

nikstur commented Oct 11, 2025

Thanks!

@nikstur nikstur added this pull request to the merge queue Oct 11, 2025
Merged via the queue into NixOS:master with commit a5152d0 Oct 11, 2025
32 of 36 checks passed
@trofi trofi deleted the systemd-fix-test-eval branch October 11, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: systemd Software suite that provides an array of system components for Linux operating systems. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants