Skip to content

libraspberrypi: fix cmake 4 compatibility#450828

Closed
SkohTV wants to merge 1 commit intoNixOS:masterfrom
SkohTV:cmake-fix-libraspberrypi
Closed

libraspberrypi: fix cmake 4 compatibility#450828
SkohTV wants to merge 1 commit intoNixOS:masterfrom
SkohTV:cmake-fix-libraspberrypi

Conversation

@SkohTV
Copy link
Member

@SkohTV SkohTV commented Oct 10, 2025

Fix #450795
Tracking #445447
Worth noting, the original repo https://github.com/raspberrypi/userland got archived recently, so no luck getting this patch merged upstream

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Oct 10, 2025
@nix-owners nix-owners bot requested review from dezgeg and tkerber October 10, 2025 23:01
@SkohTV
Copy link
Member Author

SkohTV commented Oct 10, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 450828
Commit: 567bfe44f80344968f2d748bb38a741b9a1cc618


x86_64-linux

✅ 3 packages built:
  • libraspberrypi
  • octoprint
  • octoprint.dist

@SchweGELBin
Copy link
Member

You might also update to the newest unstable version.
I prefer this approach using a patch over the approach in #449772 using a cmake flag.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 11, 2025
@SFrijters
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 450828
Commit: 567bfe44f80344968f2d748bb38a741b9a1cc618


x86_64-linux

✅ 3 packages built:
  • libraspberrypi
  • octoprint
  • octoprint.dist

aarch64-linux

✅ 4 packages built:
  • libraspberrypi
  • octoprint
  • octoprint.dist
  • raspberrypi-eeprom

@SkohTV SkohTV marked this pull request as draft October 12, 2025 14:59
@fpletz
Copy link
Member

fpletz commented Oct 13, 2025

Thank you! We'll go with #449772 for now.

@fpletz fpletz closed this Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failure: libraspberrypi

4 participants