Skip to content

lomiri.*: Fix CMake 4 compat#450821

Merged
LordGrimmauld merged 15 commits intoNixOS:masterfrom
OPNA2608:fix/lomiri/cmake4
Oct 15, 2025
Merged

lomiri.*: Fix CMake 4 compat#450821
LordGrimmauld merged 15 commits intoNixOS:masterfrom
OPNA2608:fix/lomiri/cmake4

Conversation

@OPNA2608
Copy link
Contributor

@OPNA2608 OPNA2608 commented Oct 10, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Oct 10, 2025
@OPNA2608 OPNA2608 marked this pull request as ready for review October 11, 2025 14:37
@nix-owners nix-owners bot requested review from edwtjo and onny October 11, 2025 14:39
@nixpkgs-ci nixpkgs-ci bot added 9.needs: reviewer This PR currently has no reviewers requested and needs attention. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 11, 2025
@grimmauld-bot
Copy link

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 450821
Commit: 966f3988e607730b03fd7f95fd0a2de30f3895d8


x86_64-linux

⏩ 3 packages marked as broken and skipped:
  • deltatouch
  • lomiri.morph-browser
  • lomiri.morph-browser.doc
❌ 19 packages failed to build:
  • dbus-cpp
  • dbus-cpp.dev
  • dbus-cpp.doc
  • dbus-cpp.examples
  • lomiri.biometryd
  • lomiri.biometryd.dev
  • lomiri.lomiri
  • lomiri.lomiri-filemanager-app
  • lomiri.lomiri-music-app
  • lomiri.lomiri-session
  • lomiri.lomiri-system-settings
  • lomiri.lomiri-system-settings-unwrapped
  • lomiri.lomiri-system-settings-unwrapped.dev
  • lomiri.mediascanner2
  • lomiri.mediascanner2.dev
  • lomiri.trust-store
  • lomiri.trust-store.bin
  • lomiri.trust-store.dev
  • lomiri.trust-store.doc
✅ 63 packages built:
  • ayatana-indicator-bluetooth
  • ayatana-indicator-datetime
  • ayatana-indicator-display
  • ayatana-indicator-power
  • ayatana-indicator-session
  • ayatana-indicator-sound
  • libayatana-common
  • libqtdbusmock
  • libqtdbustest
  • libsForQt5.quickflux (plasma5Packages.quickflux)
  • libsForQt5.quickflux.dev (plasma5Packages.quickflux.dev)
  • lomiri.geonames
  • lomiri.geonames.bin
  • lomiri.geonames.dev
  • lomiri.geonames.devdoc
  • lomiri.gmenuharness
  • lomiri.libusermetrics
  • lomiri.libusermetrics.dev
  • lomiri.libusermetrics.doc
  • lomiri.lomiri-api
  • lomiri.lomiri-api.dev
  • lomiri.lomiri-api.doc
  • lomiri.lomiri-app-launch
  • lomiri.lomiri-app-launch.dev
  • lomiri.lomiri-app-launch.doc
  • lomiri.lomiri-calendar-app
  • lomiri.lomiri-camera-app
  • lomiri.lomiri-clock-app
  • lomiri.lomiri-content-hub
  • lomiri.lomiri-content-hub.dev
  • lomiri.lomiri-content-hub.doc
  • lomiri.lomiri-content-hub.examples
  • lomiri.lomiri-docviewer-app
  • lomiri.lomiri-download-manager
  • lomiri.lomiri-download-manager.dev
  • lomiri.lomiri-download-manager.doc
  • lomiri.lomiri-gallery-app
  • lomiri.lomiri-indicator-datetime
  • lomiri.lomiri-indicator-network
  • lomiri.lomiri-indicator-network.dev
  • lomiri.lomiri-indicator-network.doc
  • lomiri.lomiri-mediaplayer-app
  • lomiri.lomiri-notifications
  • lomiri.lomiri-polkit-agent
  • lomiri.lomiri-push-qml
  • lomiri.lomiri-settings-components
  • lomiri.lomiri-telephony-service
  • lomiri.lomiri-thumbnailer
  • lomiri.lomiri-thumbnailer.dev
  • lomiri.lomiri-thumbnailer.doc
  • lomiri.lomiri-url-dispatcher
  • lomiri.lomiri-url-dispatcher.dev
  • lomiri.lomiri-url-dispatcher.lib
  • lomiri.qtmir
  • lomiri.qtmir.dev
  • lomiri.teleports
  • net-cpp
  • net-cpp.dev
  • net-cpp.doc
  • process-cpp
  • process-cpp.dev
  • properties-cpp
  • ubports-click

Error logs: `x86_64-linux`
dbus-cpp
10/15 Test #10: message_test .....................   Passed    0.02 sec
      Start 11: match_rule_test
11/15 Test #11: match_rule_test ..................   Passed    0.01 sec
      Start 12: message_router_test
12/15 Test #12: message_router_test ..............   Passed    0.02 sec
      Start 13: service_test
13/15 Test #13: service_test .....................   Passed    0.24 sec
      Start 14: service_watcher_test
14/15 Test #14: service_watcher_test .............   Passed    0.11 sec
      Start 15: signal_delivery_test
15/15 Test #15: signal_delivery_test .............   Passed    0.24 sec

93% tests passed, 1 tests failed out of 15

Total Test time (real) = 609.91 sec

The following tests FAILED:
1 - async_execution_load_test (Failed)
Errors while running CTest
make: *** [Makefile:71: test] Error 8

Copy link
Contributor

@LordGrimmauld LordGrimmauld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple notes, but overall very close.

@LordGrimmauld
Copy link
Contributor

LordGrimmauld commented Oct 14, 2025

The check fails in dbus-cpp make me unable to build the lomiri nixos test, i am hoping this one is just flaky.
Edit: was flaky.

@grimmauld-bot
Copy link

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 450821 --package nixosTests.lomiri
Commit: 966f3988e607730b03fd7f95fd0a2de30f3895d8


x86_64-linux

✅ 11 tests built:
  • nixosTests.lomiri.desktop-appinteractions
  • nixosTests.lomiri.desktop-ayatana-indicator-bluetooth
  • nixosTests.lomiri.desktop-ayatana-indicator-datetime
  • nixosTests.lomiri.desktop-ayatana-indicator-display
  • nixosTests.lomiri.desktop-ayatana-indicator-network
  • nixosTests.lomiri.desktop-ayatana-indicator-power
  • nixosTests.lomiri.desktop-ayatana-indicator-session
  • nixosTests.lomiri.desktop-ayatana-indicator-sound
  • nixosTests.lomiri.desktop-basics
  • nixosTests.lomiri.greeter
  • nixosTests.lomiri.keymap

@OPNA2608
Copy link
Contributor Author

You don't happen to have a full log for the dbus-cpp failure, do you? Would love to know if that's fixable, or just something we'll have to accept and disable the flaky test.

@OPNA2608 OPNA2608 marked this pull request as draft October 15, 2025 07:33
@LordGrimmauld
Copy link
Contributor

I do actually still have the build log! And for once i didn't accidentally override it with a new build...
dbus-cpp-log.txt

@OPNA2608
Copy link
Contributor Author

OPNA2608 commented Oct 15, 2025

I do actually still have the build log! And for once i didn't accidentally override it with a new build... dbus-cpp-log.txt

Thanks!

  • AsyncExecutionLoadTest.RepeatedlyInvokingAnAsyncFunctionWorks is hammering DBus with 5x100 requests, counts how many succeeded, and hopes to have exactly 500 successful roundtrips within 10 minutes. No reporting on what the error was that a DBus request may've run into, so hard to say why 22 of those requests failed.
    Will keep that suite enabled for now and try to make a patch that prints more useful information, to see if this is just a spurious issue with DBus (and thus not worth blocking the build on) or something that's fixable in the setup.
  • Executor.TimeoutsAreHandledCorrectly indicates that some memory corruption is happening somewhere (malloc(): unaligned fastbin chunk detected). Don't know a fix OTTOMH, and I can't reproduce it.
    I'll report it upstream and disable the affected suite, in hopes that this is an issue specifically with the way this test is written…

- Apply a patch that should make a possibly-flaky test more verbose, to ease with debugging.
- Disable the executor test suite, due to a spurious memory corruption in Executor.TimeoutsAreHandledCorrectly.
@OPNA2608
Copy link
Contributor Author

OPNA2608 commented Oct 15, 2025

Latest commit should either fix dbus-cpp, or make the output abit more verbose to help with debugging.

Command: nixpkgs-review pr 450821 --package nixosTests.lomiri

(If you want to be super thorough, some of the packages that are end-user applications also have their own VM tests, like lomiri.teleports. But I don't think any of them to have functional changes from any of this.)

@OPNA2608 OPNA2608 marked this pull request as ready for review October 15, 2025 10:11
@grimmauld-bot
Copy link

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 450821
Commit: 9e32dc6ddb6c513a6567ff366baeadd5133162af


x86_64-linux

⏩ 3 packages marked as broken and skipped:
  • deltatouch
  • lomiri.morph-browser
  • lomiri.morph-browser.doc
✅ 82 packages built:
  • ayatana-indicator-bluetooth
  • ayatana-indicator-datetime
  • ayatana-indicator-display
  • ayatana-indicator-power
  • ayatana-indicator-session
  • ayatana-indicator-sound
  • dbus-cpp
  • dbus-cpp.dev
  • dbus-cpp.doc
  • dbus-cpp.examples
  • libayatana-common
  • libqtdbusmock
  • libqtdbustest
  • libsForQt5.quickflux (plasma5Packages.quickflux)
  • libsForQt5.quickflux.dev (plasma5Packages.quickflux.dev)
  • lomiri.biometryd
  • lomiri.biometryd.dev
  • lomiri.geonames
  • lomiri.geonames.bin
  • lomiri.geonames.dev
  • lomiri.geonames.devdoc
  • lomiri.gmenuharness
  • lomiri.libusermetrics
  • lomiri.libusermetrics.dev
  • lomiri.libusermetrics.doc
  • lomiri.lomiri
  • lomiri.lomiri-api
  • lomiri.lomiri-api.dev
  • lomiri.lomiri-api.doc
  • lomiri.lomiri-app-launch
  • lomiri.lomiri-app-launch.dev
  • lomiri.lomiri-app-launch.doc
  • lomiri.lomiri-calendar-app
  • lomiri.lomiri-camera-app
  • lomiri.lomiri-clock-app
  • lomiri.lomiri-content-hub
  • lomiri.lomiri-content-hub.dev
  • lomiri.lomiri-content-hub.doc
  • lomiri.lomiri-content-hub.examples
  • lomiri.lomiri-docviewer-app
  • lomiri.lomiri-download-manager
  • lomiri.lomiri-download-manager.dev
  • lomiri.lomiri-download-manager.doc
  • lomiri.lomiri-filemanager-app
  • lomiri.lomiri-gallery-app
  • lomiri.lomiri-indicator-datetime
  • lomiri.lomiri-indicator-network
  • lomiri.lomiri-indicator-network.dev
  • lomiri.lomiri-indicator-network.doc
  • lomiri.lomiri-mediaplayer-app
  • lomiri.lomiri-music-app
  • lomiri.lomiri-notifications
  • lomiri.lomiri-polkit-agent
  • lomiri.lomiri-push-qml
  • lomiri.lomiri-session
  • lomiri.lomiri-settings-components
  • lomiri.lomiri-system-settings
  • lomiri.lomiri-system-settings-unwrapped
  • lomiri.lomiri-system-settings-unwrapped.dev
  • lomiri.lomiri-telephony-service
  • lomiri.lomiri-thumbnailer
  • lomiri.lomiri-thumbnailer.dev
  • lomiri.lomiri-thumbnailer.doc
  • lomiri.lomiri-url-dispatcher
  • lomiri.lomiri-url-dispatcher.dev
  • lomiri.lomiri-url-dispatcher.lib
  • lomiri.mediascanner2
  • lomiri.mediascanner2.dev
  • lomiri.qtmir
  • lomiri.qtmir.dev
  • lomiri.teleports
  • lomiri.trust-store
  • lomiri.trust-store.bin
  • lomiri.trust-store.dev
  • lomiri.trust-store.doc
  • net-cpp
  • net-cpp.dev
  • net-cpp.doc
  • process-cpp
  • process-cpp.dev
  • properties-cpp
  • ubports-click

@LordGrimmauld
Copy link
Contributor

I wouldn't be super worried about dbus-cpp, it built/tested on the community builder just fine, it might just be my laptop being cursed. If it builds on hydra, it'll be fine.
That said, it now also just succeeded on my laptop, so i am not sure what is going on.

@grimmauld-bot
Copy link

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 450821 --package nixosTests.lomiri
Commit: 6ef09c0005e5f5974cdd70d8d2422dca89ecd92d


x86_64-linux

✅ 11 tests built:
  • nixosTests.lomiri.desktop-appinteractions
  • nixosTests.lomiri.desktop-ayatana-indicator-bluetooth
  • nixosTests.lomiri.desktop-ayatana-indicator-datetime
  • nixosTests.lomiri.desktop-ayatana-indicator-display
  • nixosTests.lomiri.desktop-ayatana-indicator-network
  • nixosTests.lomiri.desktop-ayatana-indicator-power
  • nixosTests.lomiri.desktop-ayatana-indicator-session
  • nixosTests.lomiri.desktop-ayatana-indicator-sound
  • nixosTests.lomiri.desktop-basics
  • nixosTests.lomiri.greeter
  • nixosTests.lomiri.keymap

Copy link
Contributor

@LordGrimmauld LordGrimmauld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@LordGrimmauld LordGrimmauld added this pull request to the merge queue Oct 15, 2025
Merged via the queue into NixOS:master with commit 68d475d Oct 15, 2025
27 checks passed
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants