Skip to content

muparserx: fix build against CMake >= 4.0#450807

Merged
yayayayaka merged 1 commit intoNixOS:masterfrom
kilianar:muparserx-cmake
Oct 14, 2025
Merged

muparserx: fix build against CMake >= 4.0#450807
yayayayaka merged 1 commit intoNixOS:masterfrom
kilianar:muparserx-cmake

Conversation

@kilianar
Copy link
Contributor

@kilianar kilianar commented Oct 10, 2025 •
edited by yayayayaka
Loading

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. labels Oct 10, 2025
@nixpkgs-ci nixpkgs-ci bot added 9.needs: reviewer This PR currently has no reviewers requested and needs attention. 12.approvals: 1 This PR was reviewed and approved by one person. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 10, 2025
@Sigmanificient
Copy link
Member

Sigmanificient commented Oct 10, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 450807
Commit: fe3f300887c27abf24d28764a2f9ce0438b8d56c (subsequent changes)
Merge: 51c41f54879c131b9e5b50b26c9cd7c7d395ea67

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/18419367786

x86_64-linux

❌ 6 packages failed to build:
  • otb
  • pothos
  • python312Packages.pyotb
  • python312Packages.pyotb.dist
  • python313Packages.pyotb
  • python313Packages.pyotb.dist
✅ 1 package built:
  • muparserx
Error logs: `x86_64-linux`
pothos 
patching file blocks/file/BinaryFileSink.cpp
patching file blocks/file/BinaryFileSource.cpp
patching file blocks/file/TextFileSink.cpp
patching file soapy/DemoController.cpp
Running phase: updateAutotoolsGnuConfigScriptsPhase
@nix { "action": "setPhase", "phase": "updateAutotoolsGnuConfigScriptsPhase" }
Running phase: configurePhase
@nix { "action": "setPhase", "phase": "configurePhase" }
cmake flags: -DCMAKE_FIND_USE_SYSTEM_PACKAGE_REGISTRY=OFF -DCMAKE_FIND_USE_PACKAGE_REGISTRY=OFF -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON -DCMAKE_BUILD_TYPE=Release -DBUILD_TESTING=OFF -DCMAKE_INSTALL_LOCALEDIR=/nix/store/3i5h9dfv0mpcl34dwsp6hpaidcxf5g1w-pothos-0.7.1/share/locale -DCMAKE_INSTALL_LIBEXECDIR=/nix/store/3i5h9dfv0mpcl34dwsp6hpaidcxf5g1w-pothos-0.7.1/libexec -DCMAKE_INSTALL_LIBDIR=/nix/store/3i5h9dfv0mpcl34dwsp6hpaidcxf5g1w-pothos-0.7.1/lib -DCMAKE_INSTALL_DOCDIR=/nix/store/3i5h9dfv0mpcl34dwsp6hpaidcxf5g1w-pothos-0.7.1/share/doc/Pothos -DCMAKE_INSTALL_INFODIR=/nix/store/3i5h9dfv0mpcl34dwsp6hpaidcxf5g1w-pothos-0.7.1/share/info -DCMAKE_INSTALL_MANDIR=/nix/store/3i5h9dfv0mpcl34dwsp6hpaidcxf5g1w-pothos-0.7.1/share/man -DCMAKE_INSTALL_INCLUDEDIR=/nix/store/3i5h9dfv0mpcl34dwsp6hpaidcxf5g1w-pothos-0.7.1/include -DCMAKE_INSTALL_SBINDIR=/nix/store/3i5h9dfv0mpcl34dwsp6hpaidcxf5g1w-pothos-0.7.1/sbin -DCMAKE_INSTALL_BINDIR=/nix/store/3i5h9dfv0mpcl34dwsp6hpaidcxf5g1w-pothos-0.7.1/bin -DCMAKE_INSTALL_NAME_DIR=/nix/store/3i5h9dfv0mpcl34dwsp6hpaidcxf5g1w-pothos-0.7.1/lib -DCMAKE_POLICY_DEFAULT_CMP0025=NEW -DCMAKE_FIND_FRAMEWORK=LAST -DCMAKE_STRIP=/nix/store/dmypp1h4ldn0vfk3fi6yfyf5yxp9yz0k-gcc-wrapper-14.3.0/bin/strip -DCMAKE_RANLIB=/nix/store/dmypp1h4ldn0vfk3fi6yfyf5yxp9yz0k-gcc-wrapper-14.3.0/bin/ranlib -DCMAKE_AR=/nix/store/dmypp1h4ldn0vfk3fi6yfyf5yxp9yz0k-gcc-wrapper-14.3.0/bin/ar -DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++ -DCMAKE_INSTALL_PREFIX=/nix/store/3i5h9dfv0mpcl34dwsp6hpaidcxf5g1w-pothos-0.7.1
CMake Error at CMakeLists.txt:4 (cmake_minimum_required):
  Compatibility with CMake < 3.5 has been removed from CMake.

Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax

to tell CMake that the project requires at least <min> but has been updated

to work with policies introduced by <max> or earlier.


Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.


-- Configuring incomplete, errors occurred!

aarch64-linux

❌ 6 packages failed to build:
  • otb
  • pothos
  • python312Packages.pyotb
  • python312Packages.pyotb.dist
  • python313Packages.pyotb
  • python313Packages.pyotb.dist
✅ 1 package built:
  • muparserx
Error logs: `aarch64-linux`
pothos 
patching file blocks/file/BinaryFileSink.cpp
patching file blocks/file/BinaryFileSource.cpp
patching file blocks/file/TextFileSink.cpp
patching file soapy/DemoController.cpp
Running phase: updateAutotoolsGnuConfigScriptsPhase
@nix { "action": "setPhase", "phase": "updateAutotoolsGnuConfigScriptsPhase" }
Running phase: configurePhase
@nix { "action": "setPhase", "phase": "configurePhase" }
cmake flags: -DCMAKE_FIND_USE_SYSTEM_PACKAGE_REGISTRY=OFF -DCMAKE_FIND_USE_PACKAGE_REGISTRY=OFF -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON -DCMAKE_BUILD_TYPE=Release -DBUILD_TESTING=OFF -DCMAKE_INSTALL_LOCALEDIR=/nix/store/282kib1ha8s6n6qp09q5md63jfb115kv-pothos-0.7.1/share/locale -DCMAKE_INSTALL_LIBEXECDIR=/nix/store/282kib1ha8s6n6qp09q5md63jfb115kv-pothos-0.7.1/libexec -DCMAKE_INSTALL_LIBDIR=/nix/store/282kib1ha8s6n6qp09q5md63jfb115kv-pothos-0.7.1/lib -DCMAKE_INSTALL_DOCDIR=/nix/store/282kib1ha8s6n6qp09q5md63jfb115kv-pothos-0.7.1/share/doc/Pothos -DCMAKE_INSTALL_INFODIR=/nix/store/282kib1ha8s6n6qp09q5md63jfb115kv-pothos-0.7.1/share/info -DCMAKE_INSTALL_MANDIR=/nix/store/282kib1ha8s6n6qp09q5md63jfb115kv-pothos-0.7.1/share/man -DCMAKE_INSTALL_INCLUDEDIR=/nix/store/282kib1ha8s6n6qp09q5md63jfb115kv-pothos-0.7.1/include -DCMAKE_INSTALL_SBINDIR=/nix/store/282kib1ha8s6n6qp09q5md63jfb115kv-pothos-0.7.1/sbin -DCMAKE_INSTALL_BINDIR=/nix/store/282kib1ha8s6n6qp09q5md63jfb115kv-pothos-0.7.1/bin -DCMAKE_INSTALL_NAME_DIR=/nix/store/282kib1ha8s6n6qp09q5md63jfb115kv-pothos-0.7.1/lib -DCMAKE_POLICY_DEFAULT_CMP0025=NEW -DCMAKE_FIND_FRAMEWORK=LAST -DCMAKE_STRIP=/nix/store/frxwlync78r3l94863r2cbnz7ngy273j-gcc-wrapper-14.3.0/bin/strip -DCMAKE_RANLIB=/nix/store/frxwlync78r3l94863r2cbnz7ngy273j-gcc-wrapper-14.3.0/bin/ranlib -DCMAKE_AR=/nix/store/frxwlync78r3l94863r2cbnz7ngy273j-gcc-wrapper-14.3.0/bin/ar -DCMAKE_C_COMPILER=gcc -DCMAKE_CXX_COMPILER=g++ -DCMAKE_INSTALL_PREFIX=/nix/store/282kib1ha8s6n6qp09q5md63jfb115kv-pothos-0.7.1
CMake Error at CMakeLists.txt:4 (cmake_minimum_required):
  Compatibility with CMake < 3.5 has been removed from CMake.

Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax

to tell CMake that the project requires at least <min> but has been updated

to work with policies introduced by <max> or earlier.


Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.


-- Configuring incomplete, errors occurred!

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • muparserx

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • muparserx

@Sigmanificient Sigmanificient mentioned this pull request Oct 14, 2025
Open
@yayayayaka yayayayaka added this pull request to the merge queue Oct 14, 2025
Merged via the queue into NixOS:master with commit 5d64a8b Oct 14, 2025
32 of 34 checks passed
@kilianar kilianar deleted the muparserx-cmake branch October 14, 2025 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Sigmanificient Sigmanificient Sigmanificient approved these changes

@yayayayaka yayayayaka yayayayaka approved these changes

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kilianar @Sigmanificient @yayayayaka