Skip to content

mcpelauncher-{client,ui-qt}: 1.4.0-qt6 -> 1.5.3-qt6#450779

Merged
yayayayaka merged 1 commit intoNixOS:masterfrom
ungeskriptet:mcpe
Oct 14, 2025
Merged

mcpelauncher-{client,ui-qt}: 1.4.0-qt6 -> 1.5.3-qt6#450779
yayayayaka merged 1 commit intoNixOS:masterfrom
ungeskriptet:mcpe

Conversation

@ungeskriptet
Copy link
Member

@ungeskriptet ungeskriptet commented Oct 10, 2025 •
edited by yayayayaka
Loading

Fixes: #449636

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@ungeskriptet ungeskriptet mentioned this pull request Oct 10, 2025
Closed
3 tasks
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Oct 10, 2025
@Sigmanificient
Copy link
Member

Sigmanificient commented Oct 10, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 450779
Commit: ebcbaef30cca42efa46c40e170c999fa9deccabb (subsequent changes)
Merge: 4656bd83aa41b47c39d75204f1f8f1e917daae70

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/18419410029

x86_64-linux

✅ 2 packages built:
  • mcpelauncher-client
  • mcpelauncher-ui-qt

aarch64-linux

✅ 2 packages built:
  • mcpelauncher-client
  • mcpelauncher-ui-qt

SchweGELBin
SchweGELBin approved these changes Oct 11, 2025
View reviewed changes
Copy link
Member

@SchweGELBin SchweGELBin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash those commits together. Otherwise it looks good to me.
Also resolves #445447 (comment)

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 11, 2025
@Vazgen005
Copy link

Vazgen005 commented Oct 11, 2025

No sound in game.

@Vazgen005
Copy link

Vazgen005 commented Oct 11, 2025

https://minecraft-linux.github.io/troubleshooting/index.html#no-audio--music

@SchweGELBin
Copy link
Member

SchweGELBin commented Oct 11, 2025

@Vazgen005, this is a package update that also fixes build issues.
The sound problem should be addressed separately in my opinion.

ymstnt added a commit to tchfoo/raspi-dotfiles that referenced this pull request Oct 12, 2025
@ymstnt
flake.lock: Update
6cc4ebe 
Flake lock file updates:

• Updated input 'ymstnt-dotfiles':
    'github:ymstnt/dotfiles/eeb9a7ec2a85880e277c7bf35d765a7b1fe48274' (2025-10-06)
  → 'github:ymstnt/dotfiles/a44b041fb28fd3724d8bae11f60b32a8b3e12748' (2025-10-12)
• Added input 'ymstnt-dotfiles/nixpkgs-patch-mcpelauncher-ui-qt-fix-build':
    'NixOS/nixpkgs#450779'
@Sigmanificient Sigmanificient mentioned this pull request Oct 12, 2025
Open
@yayayayaka
Copy link
Member

yayayayaka commented Oct 14, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 450779
Commit: 705f376ee12c3595665fb3a64a66141c91c0fdd5

x86_64-linux

✅ 2 packages built:
  • mcpelauncher-client
  • mcpelauncher-ui-qt

@yayayayaka yayayayaka added this pull request to the merge queue Oct 14, 2025
Merged via the queue into NixOS:master with commit 22f6c43 Oct 14, 2025
31 of 33 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Oct 17, 2025

Successfully created backport PR for release-25.05:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Oct 17, 2025
Merged
1 task
@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label Oct 17, 2025
@ungeskriptet ungeskriptet deleted the mcpe branch February 22, 2026 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yayayayaka yayayayaka yayayayaka approved these changes

@phanirithvij phanirithvij Awaiting requested review from phanirithvij

@Aleksanaa Aleksanaa Awaiting requested review from Aleksanaa

+1 more reviewer

@SchweGELBin SchweGELBin SchweGELBin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update Request: mcpelauncher-ui-qt 1.4.0-qt6 → 1.5.3-qt6

6 participants

@ungeskriptet @Sigmanificient @Vazgen005 @SchweGELBin @yayayayaka @phanirithvij