Skip to content

solvespace: fix cmake4 requiring a minimum version#450608

Merged
fpletz merged 1 commit intoNixOS:masterfrom
marijanp:fix-solvespace
Oct 13, 2025
Merged

solvespace: fix cmake4 requiring a minimum version#450608
fpletz merged 1 commit intoNixOS:masterfrom
marijanp:fix-solvespace

Conversation

@marijanp
Copy link
Contributor

CMake4 now requires a minumum version.

[~]$ nix run nixpkgs#solvespace
error: Cannot build '/nix/store/ybdhkxqz0wwrlgbfwwq31kndi63ca078-solvespace-3.1.drv'.
       Reason: builder failed with exit code 1.
       Output paths:
         /nix/store/wxfbv8vzr3r30f063kq2gc7722g2nvwn-solvespace-3.1
       Last 25 log lines:
       > -- Detecting C compile features - done
       > -- Detecting CXX compiler ABI info
       > -- Detecting CXX compiler ABI info - done
       > -- Check for working CXX compiler: /nix/store/dmypp1h4ldn0vfk3fi6yfyf5yxp9yz0k-gcc-wrapper-14.3.0/bin/g++ - skipped
       > -- Detecting CXX compile features
       > -- Detecting CXX compile features - done
       > -- Performing Test HAS_FILE_PREFIX_MAP
       > -- Performing Test HAS_FILE_PREFIX_MAP - Success
       > -- Found OpenMP_C: -fopenmp (found version "4.5")
       > -- Found OpenMP_CXX: -fopenmp (found version "4.5")
       > -- Found OpenMP: TRUE (found version "4.5")
       > -- found OpenMP, compiling with flags: -fopenmp
       > -- Using in-tree libdxfrw
       > -- Using in-tree mimalloc
       > CMake Error at extlib/mimalloc/CMakeLists.txt:1 (cmake_minimum_required):
       >   Compatibility with CMake < 3.5 has been removed from CMake.
       >
       >   Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
       >   to tell CMake that the project requires at least <min> but has been updated
       >   to work with policies introduced by <max> or earlier.
       >
       >   Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.
       >
       > 
       > -- Configuring incomplete, errors occurred!
       For full logs, run:
         nix log /nix/store/ybdhkxqz0wwrlgbfwwq31kndi63ca078-solvespace-3.1.drv

I've added a cmakeFlag -DCMAKE_POLICY_VERSION_MINIMUM=3.5 similar to #449468

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@marijanp marijanp requested a review from toastal October 10, 2025 08:14
@marijanp marijanp self-assigned this Oct 10, 2025
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 10, 2025
@nix-owners nix-owners bot requested a review from edef1c October 10, 2025 08:19
Copy link
Contributor

@toastal toastal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm… I had to use this to fix Biboumi #449468

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 10, 2025
@qweered
Copy link
Contributor

qweered commented Oct 10, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 450608
Commit: 38bc34e8c29c855bdf8a280f6b6f858ef9264ee3 (subsequent changes)
Merge: a0ef897010cf4135e57520116aad2eb2c6d67a64

Logs: https://github.com/qweered/nixpkgs-review-gha/actions/runs/18406102434


x86_64-linux

✅ 1 package built:
  • solvespace

aarch64-linux

✅ 1 package built:
  • solvespace

Copy link
Contributor

@qweered qweered left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved automatically following the successful run of nixpkgs-review.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Oct 10, 2025
@fpletz fpletz added this pull request to the merge queue Oct 13, 2025
Merged via the queue into NixOS:master with commit dab90ff Oct 13, 2025
34 of 36 checks passed
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 3+ This PR was reviewed and approved by three or more persons. and removed 12.approvals: 2 This PR was reviewed and approved by two persons. labels Oct 13, 2025
@iedame
Copy link
Contributor

iedame commented Oct 20, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 3+ This PR was reviewed and approved by three or more persons.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants