Skip to content

aseprite: Force minimum CMake Policy Version to 3.5#450575

Merged
NickCao merged 1 commit intoNixOS:masterfrom
CrystalSplitter:fix-aseprite
Oct 10, 2025
Merged

aseprite: Force minimum CMake Policy Version to 3.5#450575
NickCao merged 1 commit intoNixOS:masterfrom
CrystalSplitter:fix-aseprite

Conversation

@CrystalSplitter
Copy link
Contributor

Set a CMake Variable to force the minimum CMake Policy Version to 3.5. This is a bit of a hack, but it builds fine, and hopefully Aseprite will update it anyways itself before this becomes an actual problem.

Fixes Issue #450572

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

This is a bit of a hack, but it builds fine, and
hopefully Aseprite will update it anyways itself before
this becomes an actual problem.

Fixes Issue NixOS#450572
@nixpkgs-ci nixpkgs-ci bot added 12.first-time contribution This PR is the author's first one; please be gentle! 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 10, 2025
@nix-owners nix-owners bot requested a review from orivej October 10, 2025 06:55
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 10, 2025
@qweered
Copy link
Contributor

qweered commented Oct 10, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 450575
Commit: e4bc3683423d57d2a3823677f64e09aedba1a578 (subsequent changes)
Merge: aa8113447887dc3032262daacd913fa497ad094c

Logs: https://github.com/qweered/nixpkgs-review-gha/actions/runs/18406117128


x86_64-linux

✅ 1 package built:
  • aseprite

aarch64-linux

✅ 1 package built:
  • aseprite

Copy link
Contributor

@qweered qweered left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved automatically following the successful run of nixpkgs-review.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Oct 10, 2025
@NickCao NickCao added this pull request to the merge queue Oct 10, 2025
Merged via the queue into NixOS:master with commit eda49fd Oct 10, 2025
34 of 37 checks passed
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 3+ This PR was reviewed and approved by three or more persons. and removed 12.approvals: 2 This PR was reviewed and approved by two persons. labels Oct 10, 2025
@CrystalSplitter CrystalSplitter deleted the fix-aseprite branch October 12, 2025 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 3+ This PR was reviewed and approved by three or more persons. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants