nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 450403
Commit: e7bb89e59d1ff7d83ab4852aae204c931cb72565

x86_64-linux

Github upstream hasn't had an update in 4 years, so using postPatch

Please submit this as a PR to upstream anyway - so this issue & fix has bigger visibility for other distros and potential forks - and vendor the patch.

I've made a PR upstream for https://github.com/jpcima/ADLplug
However for https://github.com/Wohlstand/libOPNMIDI and https://github.com/Wohlstand/libADLMIDI the fix is already upstream, but hard to add as a patch since there's a lot of commits in the way (so would need multiple patches) and is downloaded as a submodule (not sure I can patch the repo AND multiple git submodules via github patch link)

IMO, we can either :

• Keep substituteInPlace for submodules and fetchpatch for main repo
• Create custom patches that we vendor for nixpkgs for the submodules

downloaded as a submodule (not sure I can patch the repo AND multiple git submodules via github patch link)

FYI: Submodules are already resolved in the src, and fetchpatch[2,…] allow you to rewrite the paths in a patch to be applied into a different subdirectory.

Example: A patch fetched from upstream Chromium, applied to the vendored copy of Chromium inside Qt WebEngine.

downloaded as a submodule (not sure I can patch the repo AND multiple git submodules via github patch link)

FYI: Submodules are already resolved in the src, and fetchpatch[2,…] allow you to rewrite the paths in a patch to be applied into a different subdirectory.

Example: A patch fetched from upstream Chromium, applied to the vendored copy of Chromium inside Qt WebEngine.

nixpkgs/pkgs/development/libraries/qt-5/modules/qtwebengine.nix

Lines 164 to 169 in b7ec54f

	(fetchpatch2 {
	url = "https://github.com/chromium/chromium/commit/2f39ac8d0a414dd65c0e1d5aae38c8f97aa06ae9.patch";
	hash = "sha256-3kA2os0IntxIiJwzS5nPd7QWYlOWOpoLKYsOQFYv0Sk=";
	stripLen = 1;
	extraPrefix = "src/3rdparty/chromium/";
	})

extraPrefix was the missing piece, thanks !

All issues should be resolved I believe, lmk if there's anything I missed