Skip to content

petrifoo: fix cmake 4 compatibility#450386

Merged
leona-ya merged 1 commit intoNixOS:masterfrom
SkohTV:cmake-fix-petrifoo
Oct 10, 2025
Merged

petrifoo: fix cmake 4 compatibility#450386
leona-ya merged 1 commit intoNixOS:masterfrom
SkohTV:cmake-fix-petrifoo

Conversation

@SkohTV
Copy link
Member

@SkohTV SkohTV commented Oct 9, 2025 •
edited
Loading

Tracking issue #445447
Github upstream hasn't had an update in 10 years, so using postPatch

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 9, 2025
@SkohTV
Copy link
Member Author

SkohTV commented Oct 9, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 450386
Commit: d261cb4c47473711e010c4143e4cc6807153b4ad

x86_64-linux

✅ 1 package built:
  • petrifoo

@leona-ya leona-ya added this pull request to the merge queue Oct 10, 2025
Merged via the queue into NixOS:master with commit 229462a Oct 10, 2025
32 of 36 checks passed
@Sigmanificient Sigmanificient mentioned this pull request Oct 12, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leona-ya leona-ya leona-ya approved these changes

Assignees

No one assigned

Labels

9.needs: reviewer This PR currently has no reviewers requested and needs attention. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SkohTV @leona-ya