davix: fix minimum cmake version error#450320
Closed
guylamar2006 wants to merge 1 commit intoNixOS:masterfrom
Closed
davix: fix minimum cmake version error#450320guylamar2006 wants to merge 1 commit intoNixOS:masterfrom
guylamar2006 wants to merge 1 commit intoNixOS:masterfrom
Conversation
nixpkgs-ci
bot
added
10.rebuild-linux: 11-100
guylamar2006
force-pushed
the
davix-cmake-4
branch
from
708fbca to
e902e58
Compare
davix: fix gfal2 dependency
guylamar2006
force-pushed
the
davix-cmake-4
branch
from
e902e58 to
e6d925d
Compare
Contributor
|
@ofborg build gfal2-util gfal2-util.tests |
Contributor
|
@ofborg build gfal2 gfal2.tests |
Contributor
|
@guylamar2006 How could I validate the intended fix/improvement of this change? |
Contributor
|
|
Contributor
|
@ShamrockLee, I would suggest to upgrade davix instead, including also the patch for CMake 4 support that is already in the |
Contributor
|
@guylamar2006 @guitargeek Are these changes to address the build failure caused by |
Contributor
Author
|
yes |
Contributor
|
@guylamar2006 Thank you! The patch version bump in PR #450957 sounds like a better solution as the change is included in the upstream source. Could you also help review it? |
Contributor
Author
|
Superseded by: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix minimum cmake version error.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.