airspy, soapyairspy: fix build with cmake 4#450305
Merged
leona-ya merged 2 commits intoNixOS:masterfrom Oct 9, 2025
Merged
Conversation
Backports the commits that raise the minimum cmake version to 3.10, so the newest version of cmake doesn't complain about having removed cmake < 3.5 compatibility anymore.
nixpkgs-ci
bot
added
10.rebuild-linux: 11-100
leona-ya
approved these changes
Oct 9, 2025
panchoh
reviewed
Oct 13, 2025
| cmakeFlags = lib.optionals stdenv.hostPlatform.isLinux [ "-DINSTALL_UDEV_RULES=ON" ]; | ||
| cmakeFlags = lib.optionals stdenv.hostPlatform.isLinux [ | ||
| "-DINSTALL_UDEV_RULES=ON" | ||
| "-DCMAKE_POLICY_VERSION_MINIMUM=3.5" |
Contributor
There was a problem hiding this comment.
Suggested change
| "-DCMAKE_POLICY_VERSION_MINIMUM=3.5" |
Wouldn’t this line be redundant, since the last patch already sets it right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
Tracking issue: #445447
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.