Skip to content

julia_112{,-bin}: init at 1.12.1#450240

Merged
wegank merged 2 commits intoNixOS:masterfrom
taranarmo:julia-1.12-bin-init
Oct 23, 2025
Merged

julia_112{,-bin}: init at 1.12.1#450240
wegank merged 2 commits intoNixOS:masterfrom
taranarmo:julia-1.12-bin-init

Conversation

@taranarmo
Copy link
Contributor

@taranarmo taranarmo commented Oct 9, 2025 •
edited
Loading

https://github.com/JuliaLang/julia/releases/tag/v1.12.1

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@taranarmo taranarmo force-pushed the julia-1.12-bin-init branch from 4efed3e to e91ca64 Compare October 9, 2025 10:48
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 6.topic: julia Julia is a high-level, high-performance dynamic language for technical computing. labels Oct 9, 2025
@NickCao
Copy link
Member

NickCao commented Oct 9, 2025

And also add the source version?

@taranarmo
Copy link
Contributor Author

taranarmo commented Oct 10, 2025

And also add the source version?

That was the plan but I can't build it. Will try today again.

@taranarmo taranarmo changed the title julia_112-bin: init at 1.12.0 julia_112{,-bin}: init at 1.12.0 Oct 10, 2025
@taranarmo taranarmo force-pushed the julia-1.12-bin-init branch 2 times, most recently from fc1c8d6 to ba1ae2d Compare October 10, 2025 11:04
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. and removed 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Oct 10, 2025
@taranarmo
Copy link
Contributor Author

taranarmo commented Oct 10, 2025

my current approach fails on darwin on testing, tried to fix without success
https://github.com/taranarmo/nixpkgs-review-gha/actions/runs/18404654703/job/52441675806

@taranarmo taranarmo force-pushed the julia-1.12-bin-init branch from ba1ae2d to 9c31b2c Compare October 16, 2025 07:26
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. and removed 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Oct 16, 2025
@wegank
Copy link
Member

wegank commented Oct 17, 2025

julia_112-bin builds fine on my aarch64-darwin machine.

@wegank
Copy link
Member

wegank commented Oct 18, 2025

Julia 1.12.1 is out: https://github.com/JuliaLang/julia/releases/tag/v1.12.1

@taranarmo
Copy link
Contributor Author

taranarmo commented Oct 18, 2025

julia_112-bin builds fine on my aarch64-darwin machine

Probably disabling Distributed test helped

I will update to 1.12.1 then

@taranarmo taranarmo changed the title julia_112{,-bin}: init at 1.12.0 julia_112{,-bin}: init at 1.12.1 Oct 18, 2025
@taranarmo taranarmo force-pushed the julia-1.12-bin-init branch from 9c31b2c to 89ad607 Compare October 18, 2025 11:03
@taranarmo
Copy link
Contributor Author

taranarmo commented Oct 18, 2025

Updated to 1.12.1, building locally now, marking ready for review

@taranarmo taranarmo marked this pull request as ready for review October 18, 2025 11:10
@nix-owners nix-owners bot requested review from NickCao and thomasjm October 18, 2025 11:12
@b-rodrigues b-rodrigues mentioned this pull request Oct 19, 2025
Closed
3 tasks
@b-rodrigues
Copy link
Contributor

b-rodrigues commented Oct 19, 2025

I'm not able to build it on x86_64-linux:

ERROR: LoadError: Test run finished with errors
in expression starting at /build/julia-1.12.1/test/runtests.jl:92
make[1]: *** [Makefile:32: all] Error 1
make: *** [Makefile:671: testall] Error 2
error: builder for '/nix/store/as682cn8bgji5190b66c54z0wgllc16v-julia-1.12.1.drv' failed with exit code 2;
       last 25 log lines:
       >     Test                                            |      521            17       538   1m08.7s
       >     Random                                          |   219383                  219383   1m43.8s
       >     SparseArrays/linalg                             |     3774                    3774   3m49.2s
       >     compileall                                      |        2                       2   5m19.6s
       >     Profile                                         |    20163             1     20164   2m44.5s
       >     SparseArrays/sparsematrix_constructors_indexing |     2218                    2218   4m31.9s
       >     SparseArrays/sparsevector                       |    11999             4     12003   9m36.8s
       >     precompile                                      |      333     1               334   1m41.9s
       >     SharedArrays                                    |      119                     119     17.8s
       >     threads                                         |      167                     167  12m06.3s
       >     gc                                              |       56                      56     45.5s
       >     stress                                          |      118                     118     11.7s
       >     FAILURE
       >
       > The global RNG seed was 0x579192695ca627159a86f6c47d322533.
       >
       > Error in testset precompile:
       > Test Failed at /build/julia-1.12.1/test/precompile.jl:1435
       >   Expression: read(fname, String) == "Iterators\n"
       >    Evaluated: "Precompiling packages...\n    507.3 ms  ✓ Test6c92f26 (serial)\n  1 dependency successfully precompiled in 1 seconds\nIterators\n" == "Iterators\n"
       >
       > ERROR: LoadError: Test run finished with errors
       > in expression starting at /build/julia-1.12.1/test/runtests.jl:92
       > make[1]: *** [Makefile:32: all] Error 1
       > make: *** [Makefile:671: testall] Error 2
       For full logs, run:
         nix log /nix/store/as682cn8bgji5190b66c54z0wgllc16v-julia-1.12.1.drv

@wegank
Copy link
Member

wegank commented Oct 19, 2025

Same regression on aarch64-darwin.

@taranarmo
Copy link
Contributor Author

taranarmo commented Oct 19, 2025

I am locating tests to disable, currently precompile and compileall, for binary compiler/codegen became Compiler/codegen

@taranarmo taranarmo force-pushed the julia-1.12-bin-init branch from 89ad607 to 1ef9f2d Compare October 19, 2025 22:33
@nixpkgs-ci nixpkgs-ci bot removed the 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. label Oct 19, 2025
@taranarmo taranarmo force-pushed the julia-1.12-bin-init branch from 1bf1948 to 69b1c3a Compare October 20, 2025 08:19
@b-rodrigues
Copy link
Contributor

b-rodrigues commented Oct 20, 2025

Can confirm this works on x86_64-linux now!

wegank
wegank reviewed Oct 20, 2025
View reviewed changes
@taranarmo taranarmo force-pushed the julia-1.12-bin-init branch from 69b1c3a to ed5d575 Compare October 21, 2025 07:39
@taranarmo
Copy link
Contributor Author

taranarmo commented Oct 21, 2025 •
edited
Loading

made export JULIA_TEST_USE_MULTIPLE_WORKERS=ture conditional for isLinux in julia-bin (defaults to false upstream if not set and should disable Distributed and addproc functionality), ofborg built both Julias on Linux yesterday so fingers crossed

upd: it didn't work for Darwin either, suggestions welcomed

@taranarmo taranarmo force-pushed the julia-1.12-bin-init branch from ed5d575 to 3b219e0 Compare October 21, 2025 07:53
wegank
wegank reviewed Oct 21, 2025
View reviewed changes
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Oct 21, 2025
@taranarmo taranarmo force-pushed the julia-1.12-bin-init branch from 3b219e0 to 8c2df66 Compare October 22, 2025 07:11
@thomasjm thomasjm mentioned this pull request Oct 22, 2025
Merged
13 tasks
@taranarmo
Copy link
Contributor Author

taranarmo commented Oct 23, 2025

Ofborg failed to build due to Profile test, happened a couple of times before, probably we should disable it and mark flaky

@wegank
Copy link
Member

wegank commented Oct 23, 2025

Ofborg and GitHub CI may be resource-limited. I'd say as long as the package builds on Hydra, it should be fine.

@NickCao @thomasjm do you need more time to review?

thomasjm
thomasjm approved these changes Oct 23, 2025
View reviewed changes
Copy link
Contributor

@thomasjm thomasjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diff looks fine to me. I was thinking I'd start looking at julia.withPackages for 1.12 once a working 1.12 lands.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Oct 23, 2025
@taranarmo taranarmo force-pushed the julia-1.12-bin-init branch from 8c2df66 to f99dc06 Compare October 23, 2025 13:29
@wegank wegank added this pull request to the merge queue Oct 23, 2025
Merged via the queue into NixOS:master with commit 0f00965 Oct 23, 2025
26 of 30 checks passed
@taranarmo taranarmo mentioned this pull request Oct 29, 2025
Merged
13 tasks
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Oct 31, 2025

Successfully created backport PR for release-25.05:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Oct 31, 2025
Merged
1 task
@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label Oct 31, 2025
@taranarmo taranarmo deleted the julia-1.12-bin-init branch October 31, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wegank wegank wegank approved these changes

@NickCao NickCao Awaiting requested review from NickCao

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

+1 more reviewer

@thomasjm thomasjm thomasjm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: julia Julia is a high-level, high-performance dynamic language for technical computing. 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@taranarmo @NickCao @wegank @b-rodrigues @thomasjm @vbgl