Skip to content

ettercap: 0.8.3.1 -> 0.8.4-unstable-2025-07-16#450238

Merged
SuperSandro2000 merged 3 commits intoNixOS:masterfrom
fabaff:ettercap-fix
Oct 9, 2025
Merged

ettercap: 0.8.3.1 -> 0.8.4-unstable-2025-07-16#450238
SuperSandro2000 merged 3 commits intoNixOS:masterfrom
fabaff:ettercap-fix

Conversation

@fabaff
Copy link
Member

@fabaff fabaff commented Oct 9, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@fabaff fabaff mentioned this pull request Oct 9, 2025
Open
@fabaff
Copy link
Member Author

fabaff commented Oct 9, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 450238
Commit: 689802620f086fa789e5688bc535aad050971185

x86_64-linux

✅ 1 package built:
  • ettercap

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 9, 2025
@nix-owners nix-owners bot requested a review from pSub October 9, 2025 10:41
SuperSandro2000
SuperSandro2000 reviewed Oct 9, 2025
View reviewed changes
pkgs/by-name/et/ettercap/package.nix
Comment on lines +63 to +65
substituteInPlace CMakeLists.txt \
--replace-fail /etc \$\{INSTALL_PREFIX\}/etc \
--replace-fail /usr \$\{INSTALL_PREFIX\}
Copy link
Member

@SuperSandro2000 SuperSandro2000 Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to upstream this

@SuperSandroBot
Copy link

SuperSandroBot commented Oct 9, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 450238
Commit: 689802620f086fa789e5688bc535aad050971185 (subsequent changes)
Merge: 44439f59c6f2f74331c13dc1cf45917796041698

Logs: https://github.com/SuperSandro2000/nixpkgs-review-gha/actions/runs/18376482762

x86_64-linux

✅ 1 package built:
  • ettercap

aarch64-linux

✅ 1 package built:
  • ettercap

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • ettercap

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • ettercap

@SuperSandro2000 SuperSandro2000 added this pull request to the merge queue Oct 9, 2025
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 9, 2025
Merged via the queue into NixOS:master with commit 95ca02e Oct 9, 2025
32 of 36 checks passed
@fabaff fabaff deleted the ettercap-fix branch October 9, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@pSub pSub Awaiting requested review from pSub

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fabaff @SuperSandroBot @SuperSandro2000