Skip to content

argtable: 3.2.2 -> 3.3.1#450094

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
keenanweaver:argtable-cmake-fix
Oct 9, 2025
Merged

argtable: 3.2.2 -> 3.3.1#450094
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
keenanweaver:argtable-cmake-fix

Conversation

@keenanweaver
Copy link
Member

@keenanweaver keenanweaver commented Oct 8, 2025

  • Bumps to latest

Part of #445447

Changelog: https://github.com/argtable/argtable3/releases/tag/v3.3.1
Compare: argtable/argtable3@v3.2.2.f25c624...v3.3.1

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Oct 8, 2025
@keenanweaver
Copy link
Member Author

keenanweaver commented Oct 8, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 450094
Commit: 0128d0c84321bd132c570643a65e2809eeb74d69 (subsequent changes)
Merge: 49dcfbf37491c53e3b9c2ec24b5d8e6e59b3234a

Logs: https://github.com/keenanweaver/nixpkgs-review-gha/actions/runs/18359726072

x86_64-linux

❌ 1 package failed to build:
  • libjson-rpc-cpp
✅ 6 packages built:
  • argtable
  • astroterm
  • blisp
  • clustal-omega
  • openomf
  • pineflash
Error logs: `x86_64-linux`
libjson-rpc-cpp 
unpacking source archive /nix/store/sj9c9p73wq0v356hs7b6hng5642341l9-source
source root is source
Running phase: patchPhase
@nix { "action": "setPhase", "phase": "patchPhase" }
Running phase: updateAutotoolsGnuConfigScriptsPhase
@nix { "action": "setPhase", "phase": "updateAutotoolsGnuConfigScriptsPhase" }
Running phase: configurePhase
@nix { "action": "setPhase", "phase": "configurePhase" }
/build/source/Build /build/source
CMake Error at CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 3.5 has been removed from CMake.

Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax

to tell CMake that the project requires at least <min> but has been updated

to work with policies introduced by <max> or earlier.


Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.


-- Configuring incomplete, errors occurred!

aarch64-linux

❌ 1 package failed to build:
  • libjson-rpc-cpp
✅ 6 packages built:
  • argtable
  • astroterm
  • blisp
  • clustal-omega
  • openomf
  • pineflash
Error logs: `aarch64-linux`
libjson-rpc-cpp 
unpacking source archive /nix/store/sj9c9p73wq0v356hs7b6hng5642341l9-source
source root is source
Running phase: patchPhase
@nix { "action": "setPhase", "phase": "patchPhase" }
Running phase: updateAutotoolsGnuConfigScriptsPhase
@nix { "action": "setPhase", "phase": "updateAutotoolsGnuConfigScriptsPhase" }
Running phase: configurePhase
@nix { "action": "setPhase", "phase": "configurePhase" }
/build/source/Build /build/source
CMake Error at CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 3.5 has been removed from CMake.

Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax

to tell CMake that the project requires at least <min> but has been updated

to work with policies introduced by <max> or earlier.


Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.


-- Configuring incomplete, errors occurred!

x86_64-darwin (sandbox = true)

✅ 5 packages built:
  • argtable
  • astroterm
  • blisp
  • clustal-omega
  • openomf

aarch64-darwin (sandbox = true)

✅ 5 packages built:
  • argtable
  • astroterm
  • blisp
  • clustal-omega
  • openomf

@keenanweaver keenanweaver marked this pull request as ready for review October 8, 2025 22:43
@keenanweaver keenanweaver mentioned this pull request Oct 8, 2025
Closed
13 tasks
@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Oct 9, 2025
@srounce
Copy link
Contributor

srounce commented Oct 9, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 450094
Commit: 0128d0c84321bd132c570643a65e2809eeb74d69

x86_64-linux

❌ 1 package failed to build:
  • libjson-rpc-cpp
✅ 6 packages built:
  • argtable
  • astroterm
  • blisp
  • clustal-omega
  • openomf
  • pineflash
Error logs: `x86_64-linux`
libjson-rpc-cpp 
unpacking source archive /nix/store/sj9c9p73wq0v356hs7b6hng5642341l9-source
source root is source
Running phase: patchPhase
@nix { "action": "setPhase", "phase": "patchPhase" }
Running phase: updateAutotoolsGnuConfigScriptsPhase
@nix { "action": "setPhase", "phase": "updateAutotoolsGnuConfigScriptsPhase" }
Running phase: configurePhase
@nix { "action": "setPhase", "phase": "configurePhase" }
/build/source/Build /build/source
CMake Error at CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 3.5 has been removed from CMake.

Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax

to tell CMake that the project requires at least <min> but has been updated

to work with policies introduced by <max> or earlier.


Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.


-- Configuring incomplete, errors occurred!

srounce
srounce approved these changes Oct 9, 2025
View reviewed changes
Copy link
Contributor

@srounce srounce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 9, 2025
SuperSandro2000
SuperSandro2000 reviewed Oct 9, 2025
View reviewed changes
pkgs/by-name/ar/argtable/package.nix
Comment on lines +28 to +30
substituteInPlace pkgconfig.pc.in \
--replace-fail "\''${prefix}/@CMAKE_INSTALL_INCLUDEDIR@" "@CMAKE_INSTALL_FULL_INCLUDEDIR@" \
--replace-fail "\''${prefix}/@CMAKE_INSTALL_LIBDIR@" "@CMAKE_INSTALL_FULL_LIBDIR@"
Copy link
Member

@SuperSandro2000 SuperSandro2000 Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to upstream this

@SuperSandro2000 SuperSandro2000 added this pull request to the merge queue Oct 9, 2025
Merged via the queue into NixOS:master with commit 178325c Oct 9, 2025
32 of 36 checks passed
This was referenced Oct 9, 2025
Closed
Closed
@Sigmanificient Sigmanificient mentioned this pull request Oct 12, 2025
Open
@keenanweaver keenanweaver deleted the argtable-cmake-fix branch October 13, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

+1 more reviewer

@srounce srounce srounce approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@keenanweaver @srounce @SuperSandro2000