Skip to content

miniz: 3.0.2 -> 3.1.0#450072

Merged
niklaskorz merged 1 commit intoNixOS:masterfrom
marcin-serwin:push-toqlosuvzzku
Oct 9, 2025
Merged

miniz: 3.0.2 -> 3.1.0#450072
niklaskorz merged 1 commit intoNixOS:masterfrom
marcin-serwin:push-toqlosuvzzku

Conversation

@marcin-serwin
Copy link
Contributor

@marcin-serwin marcin-serwin commented Oct 8, 2025 •
edited by niklaskorz
Loading

cc #445447

Changelog: https://github.com/richgel999/miniz/releases/tag/3.1.0

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@marcin-serwin
miniz: 3.0.2 -> 3.1.0
ca1139d 
Signed-off-by: Marcin Serwin <[email protected]>
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Oct 8, 2025
@nix-owners nix-owners bot requested a review from astro October 8, 2025 21:33
@marcin-serwin marcin-serwin mentioned this pull request Oct 8, 2025
Merged
niklaskorz
niklaskorz approved these changes Oct 9, 2025
View reviewed changes
Copy link
Member

@niklaskorz niklaskorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shader-slang builds fine, thx! edgetx is failing because it is actually using a vendored miniz instead of the nixpkgs one, so that is unrelated to this PR.

miniz pkg-config test is failing, but that is also unrelated; I'll merge this to unblock miniz dependants and we can look into that separately

@niklaskorz niklaskorz added this pull request to the merge queue Oct 9, 2025
Merged via the queue into NixOS:master with commit d71ccb2 Oct 9, 2025
33 of 37 checks passed
@niklaskorz niklaskorz mentioned this pull request Oct 9, 2025
Open
@Sigmanificient
Copy link
Member

Sigmanificient commented Oct 9, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 450072
Commit: ca1139d8a01eb624051e31202a9f7738664c91cd (subsequent changes)
Merge: 0ed3718c73eb4b5c3bd5cc52c2bc7c5d346b2e5a

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/18372280546

x86_64-linux

❌ 1 package failed to build:
  • edgetx
✅ 8 packages built:
  • miniz
  • shader-slang
  • shader-slang.debug
  • shader-slang.dev
  • shader-slang.doc
  • tests.testers.hasPkgConfigModules.miniz-no-versionCheck
  • tests.testers.hasPkgConfigModules.miniz-versions-match
  • tests.testers.hasPkgConfigModules.miniz-versions-mismatch
Error logs: `x86_64-linux`
edgetx 
-- Found Threads: TRUE
-- Simulators library search path: ../lib/companion211
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success
Fetched miniz source code from Github: /nix/store/3llrzjqvmcm363rksfvj1p9jbc3f79rm-source
CMake Error at /nix/store/8w97waa66wfs4jkcz7rrd1gwyzhn09wg-source/CMakeLists.txt:2 (cmake_minimum_required):
  Compatibility with CMake < 3.5 has been removed from CMake.

Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax

to tell CMake that the project requires at least <min> but has been updated

to work with policies introduced by <max> or earlier.


Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.


-- Configuring incomplete, errors occurred!

aarch64-linux

❌ 1 package failed to build:
  • edgetx
✅ 8 packages built:
  • miniz
  • shader-slang
  • shader-slang.debug
  • shader-slang.dev
  • shader-slang.doc
  • tests.testers.hasPkgConfigModules.miniz-no-versionCheck
  • tests.testers.hasPkgConfigModules.miniz-versions-match
  • tests.testers.hasPkgConfigModules.miniz-versions-mismatch
Error logs: `aarch64-linux`
edgetx 
-- Found Threads: TRUE
-- Simulators library search path: ../lib/companion211
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY
-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR
-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success
Fetched miniz source code from Github: /nix/store/3llrzjqvmcm363rksfvj1p9jbc3f79rm-source
CMake Error at /nix/store/8w97waa66wfs4jkcz7rrd1gwyzhn09wg-source/CMakeLists.txt:2 (cmake_minimum_required):
  Compatibility with CMake < 3.5 has been removed from CMake.

Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax

to tell CMake that the project requires at least <min> but has been updated

to work with policies introduced by <max> or earlier.


Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.


-- Configuring incomplete, errors occurred!

x86_64-darwin (sandbox = true)

✅ 7 packages built:
  • miniz
  • shader-slang
  • shader-slang.dev
  • shader-slang.doc
  • tests.testers.hasPkgConfigModules.miniz-no-versionCheck
  • tests.testers.hasPkgConfigModules.miniz-versions-match
  • tests.testers.hasPkgConfigModules.miniz-versions-mismatch

aarch64-darwin (sandbox = true)

✅ 7 packages built:
  • miniz
  • shader-slang
  • shader-slang.dev
  • shader-slang.doc
  • tests.testers.hasPkgConfigModules.miniz-no-versionCheck
  • tests.testers.hasPkgConfigModules.miniz-versions-match
  • tests.testers.hasPkgConfigModules.miniz-versions-mismatch

@marcin-serwin marcin-serwin deleted the push-toqlosuvzzku branch October 16, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@niklaskorz niklaskorz niklaskorz approved these changes

@astro astro Awaiting requested review from astro

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marcin-serwin @Sigmanificient @niklaskorz