Skip to content

ccls: fix build#450049

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
geodic:ccls
Oct 10, 2025
Merged

ccls: fix build#450049
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
geodic:ccls

Conversation

@geodic
Copy link
Contributor

@geodic geodic commented Oct 8, 2025

The version of the llvmPackages package set was recently updated from 19 to 21, breaking a few packages. This PR explicitly uses the older package set to fix the ccls package.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 8, 2025
@nix-owners nix-owners bot requested review from Mic92 and tobim October 8, 2025 20:29
@Sigmanificient
Copy link
Member

Sigmanificient commented Oct 9, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 450049
Commit: 4f449058eefa05b07f1ddbcf5c62908732ca6503 (subsequent changes)
Merge: 0262f12a8a51d3d9585e3b4a5d9a242ae1fda84f

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/18372282184

x86_64-linux

✅ 1 package built:
  • ccls

aarch64-linux

✅ 1 package built:
  • ccls

x86_64-darwin (sandbox = true)

✅ 1 package built:
  • ccls

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • ccls

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 9, 2025
@tobim
Copy link
Contributor

tobim commented Oct 9, 2025

I asked for a new release upstream, let's give them a few days. We can still implement a workaround if they don't respond.

MaskRay/ccls#987

@bjornfor bjornfor mentioned this pull request Oct 10, 2025
Closed
13 tasks
@uninsane
Copy link
Contributor

uninsane commented Oct 10, 2025

what's the rationale to delay merging? the build is currently broken: this PR seems like a strictly better place for nixpkgs master to be in & i don't see how delaying this is saving anybody (users, maintainers, reviewers) any measurable work.

@SuperSandro2000 SuperSandro2000 added this pull request to the merge queue Oct 10, 2025
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Oct 10, 2025

We can still implement a workaround if they don't respond.

We already have that in the PR, we don't need to implement anything further.

Also collecting one year of development in a new release might unlock the next problem.

Merged via the queue into NixOS:master with commit 4c5e6a1 Oct 10, 2025
34 of 36 checks passed
@khaneliman khaneliman mentioned this pull request Oct 12, 2025
Closed
3 tasks
@Sigmanificient Sigmanificient mentioned this pull request Oct 12, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@tobim tobim Awaiting requested review from tobim

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@geodic @Sigmanificient @tobim @uninsane @SuperSandro2000