Skip to content

mozjpeg: add cmakeFlags for CMake >= 3.5#450028

Merged
fabaff merged 1 commit intoNixOS:masterfrom
fabaff:mozjpeg-fix
Oct 8, 2025
Merged

mozjpeg: add cmakeFlags for CMake >= 3.5#450028
fabaff merged 1 commit intoNixOS:masterfrom
fabaff:mozjpeg-fix

Conversation

@fabaff
Copy link
Member

@fabaff fabaff commented Oct 8, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@fabaff fabaff mentioned this pull request Oct 8, 2025
Open
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Oct 8, 2025
@nix-owners nix-owners bot requested a review from aristidb October 8, 2025 19:07
@fabaff
Copy link
Member Author

fabaff commented Oct 8, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 450028
Commit: 37bc5002ebe3a112e85a88d9232842cccd759087

x86_64-linux

✅ 10 packages built:
  • avocode
  • image_optim
  • jpeg-archive
  • kcc
  • kcc.dist
  • mozjpeg
  • python312Packages.mozjpeg_lossless_optimization
  • python312Packages.mozjpeg_lossless_optimization.dist
  • python313Packages.mozjpeg_lossless_optimization
  • python313Packages.mozjpeg_lossless_optimization.dist

@fabaff fabaff added this pull request to the merge queue Oct 8, 2025
Merged via the queue into NixOS:master with commit f02eff4 Oct 8, 2025
28 checks passed
@fabaff fabaff deleted the mozjpeg-fix branch October 8, 2025 19:15
@LunNova
Copy link
Member

LunNova commented Oct 8, 2025 •
edited
Loading

Please prefer to use other approaches when possible. I was unable to post this as a review in time due to the fast self-merge.

Reminder for everyone (especially … who opened a lot of these): Patches are preferable over the cmake flag, because patches will start failing once upstream merges and releases cmake fixes. This ensures patches won't stay in nixpkgs forever. Contrary, passing a -DCMAKE_POLICY_VERSION_MINIMUM flag will only hard-fail once something else breaks in unforeseen ways and will be hard to debug and likely forgotten. Please please please prefer patches, unless there is very good reason not to. I can be convinced to accept substituteInPlace --replace-fail, but cmake flag is probably never the best option.

Originally posted by @LordGrimmauld in #445447

@LunNova LunNova mentioned this pull request Oct 8, 2025
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aristidb aristidb Awaiting requested review from aristidb

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fabaff @LunNova