Skip to content

hyperscan: add cmakeFlags for CMake >= 3.5#450025

Closed
fabaff wants to merge 1 commit intoNixOS:masterfrom
fabaff:hyperscan-fix
Closed

hyperscan: add cmakeFlags for CMake >= 3.5#450025
fabaff wants to merge 1 commit intoNixOS:masterfrom
fabaff:hyperscan-fix

Conversation

@fabaff
Copy link
Member

@fabaff fabaff commented Oct 8, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@fabaff fabaff mentioned this pull request Oct 8, 2025
Open
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Oct 8, 2025
@nix-owners nix-owners bot requested a review from avnik October 8, 2025 18:54
@fabaff fabaff marked this pull request as draft October 8, 2025 19:30
LunNova
LunNova previously requested changes Oct 8, 2025
View reviewed changes
Copy link
Member

@LunNova LunNova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use an alternative approach as documented in #445447 unless applying a policy minimum like this is the only viable option.

@Sigmanificient Sigmanificient requested a review from iedame October 23, 2025 19:14
@Sigmanificient Sigmanificient marked this pull request as ready for review October 23, 2025 19:15
@iedame
Copy link
Contributor

iedame commented Oct 23, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 450025
Commit: 8fa90812c4512b3a7af663e1cd93a90c27c062a1 (subsequent changes)
Merge: c4677ee1e7ad6193e0cf6d4d871ba5bc8656be1d

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18759422433

x86_64-linux

❌ 4 packages failed to build:
  • python312Packages.hyperscan
  • python312Packages.hyperscan.dist
  • python313Packages.hyperscan
  • python313Packages.hyperscan.dist
✅ 4 packages built:
  • hyperscan
  • hyperscan.dev
  • rimsort
  • todds

aarch64-linux

✅ No rebuilds

x86_64-darwin (sandbox = true)

❌ 4 packages failed to build:
  • python312Packages.hyperscan
  • python312Packages.hyperscan.dist
  • python313Packages.hyperscan
  • python313Packages.hyperscan.dist
✅ 2 packages built:
  • hyperscan
  • hyperscan.dev

aarch64-darwin

✅ No rebuilds

@iedame
Copy link
Contributor

iedame commented Oct 23, 2025 

2025-10-23T19:27:58.5490050Z hyperscan> -- PCRE version 8.41 or above - building from source.
2025-10-23T19:27:58.5544660Z hyperscan> CMake Error at pcre/CMakeLists.txt:79 (CMAKE_MINIMUM_REQUIRED):
2025-10-23T19:27:58.5599430Z hyperscan>   Compatibility with CMake < 3.5 has been removed from CMake.
2025-10-23T19:27:58.5658770Z hyperscan> 
2025-10-23T19:27:58.5675140Z hyperscan>   Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
2025-10-23T19:27:58.5776590Z hyperscan>   to tell CMake that the project requires at least <min> but has been updated
2025-10-23T19:27:58.5777670Z hyperscan>   to work with policies introduced by <max> or earlier.
2025-10-23T19:27:58.5881280Z hyperscan> 
2025-10-23T19:27:58.5983380Z hyperscan>   Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.
2025-10-23T19:27:58.6084970Z hyperscan> 
2025-10-23T19:27:58.6186050Z hyperscan> 
2025-10-23T19:27:58.6283720Z hyperscan> -- Configuring incomplete, errors occurred!
2025-10-23T19:27:58.6383340Z hyperscan> -- Looking for mmap - found
2025-10-23T19:27:58.6485130Z hyperscan> -- Doxygen not found, unable to generate API reference
2025-10-23T19:27:58.6587720Z hyperscan> -- Sphinx not found, unable to generate developer reference
2025-10-23T19:27:58.6846120Z error: Cannot build '/nix/store/mk9c9lf3l843giaqrxnmxlh8x913qz13-hyperscan-5.4.2.drv'.
2025-10-23T19:27:58.6846960Z        Reason: builder failed with exit code 1.

@Sigmanificient
Copy link
Member

Sigmanificient commented Oct 23, 2025

I got the derivation to build successfully with this patch 🤔

image

@Sigmanificient
Copy link
Member

Sigmanificient commented Oct 23, 2025

@iedame do you have a discord or matrix account?

@iedame
Copy link
Contributor

iedame commented Oct 23, 2025

Do we need to patch something here too, perhaps? This one builds fine for you? It is failing with the cmake error above for me

nix-build -A python313Packages.hyperscan

https://github.com/NixOS/nixpkgs/blob/nixos-unstable/pkgs/development/python-modules/hyperscan/default.nix#L57

@Sigmanificient my matrix is @ieda:matrix.org 😄

This was referenced Oct 27, 2025
Closed
Merged
@iedame
Copy link
Contributor

iedame commented Oct 28, 2025

Closing this PR since #455992 was merged

@iedame iedame closed this Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LunNova LunNova LunNova left review comments

@avnik avnik Awaiting requested review from avnik

@iedame iedame Awaiting requested review from iedame

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fabaff @iedame @Sigmanificient @LunNova