Skip to content

safestringlib: fix minimum cmake version error#450023

Merged
r-vdp merged 1 commit intoNixOS:masterfrom
guylamar2006:safestring-cmake-error
Oct 13, 2025
Merged

safestringlib: fix minimum cmake version error#450023
r-vdp merged 1 commit intoNixOS:masterfrom
guylamar2006:safestring-cmake-error

Conversation

@guylamar2006
Copy link
Contributor

@guylamar2006 guylamar2006 commented Oct 8, 2025 •
edited
Loading

Fix minimum cmake version error to compile safestring library.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Oct 8, 2025
@nix-owners nix-owners bot requested a review from apraga October 8, 2025 18:50
@guylamar2006
Copy link
Contributor Author

guylamar2006 commented Oct 8, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 450023
Commit: 703d645eea9a2df7d0e4188f6fa19cc0108594d0 (subsequent changes)
Merge: 866d4bb7a4841816a109830758214725199190d3

Logs: https://github.com/guylamar2006/nixpkgs-review-gha/actions/runs/18354786864

x86_64-linux

✅ 2 packages built:
  • bwa-mem2
  • safestringlib

aarch64-linux

✅ 1 package built:
  • safestringlib

x86_64-darwin (sandbox = true)

✅ 2 packages built:
  • bwa-mem2
  • safestringlib

aarch64-darwin (sandbox = true)

✅ 1 package built:
  • safestringlib

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Oct 8, 2025
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Oct 8, 2025
@r-vdp r-vdp added this pull request to the merge queue Oct 13, 2025
Merged via the queue into NixOS:master with commit c101341 Oct 13, 2025
38 of 40 checks passed
@guylamar2006 guylamar2006 deleted the safestring-cmake-error branch October 13, 2025 19:58
@Sigmanificient Sigmanificient mentioned this pull request Oct 16, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@apraga apraga apraga approved these changes

@qweered qweered qweered approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@guylamar2006 @apraga @qweered @r-vdp