Skip to content

apvlv: 0.6.0 -> 0.7.0; fix build with CMake 4#450001

Merged
vcunat merged 1 commit intoNixOS:masterfrom
sternenseemann:apvlv-0.7.0
Oct 13, 2025
Merged

apvlv: 0.6.0 -> 0.7.0; fix build with CMake 4#450001
vcunat merged 1 commit intoNixOS:masterfrom
sternenseemann:apvlv-0.7.0

Conversation

@sternenseemann
Copy link
Member

@sternenseemann sternenseemann commented Oct 8, 2025 •
edited
Loading

Things done

Unfortunately open and openDir (o and O) don't seem to work yet.

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@sternenseemann sternenseemann added the 6.topic: qt/kde Object-oriented framework for GUI creation label Oct 8, 2025
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. and removed 6.topic: qt/kde Object-oriented framework for GUI creation labels Oct 8, 2025
@sternenseemann sternenseemann marked this pull request as ready for review October 8, 2025 18:17
@sternenseemann
Copy link
Member Author

sternenseemann commented Oct 8, 2025

Unfortunately open and openDir (o and O) don't seem to work yet.

As it turns out, this was caused by QT_QPA_PLATFORMTHEME=gnome on my system. Not sure if this is an issue with apvlv (which doesn't do anything fancy, just QFileDialog::getOpenFileName etc., but I opened naihe2010/apvlv#100 anyways) or Qt6.

Either way, I don't think this is our responsibility to fix!

@sternenseemann sternenseemann mentioned this pull request Oct 8, 2025
Open
@sternenseemann
Copy link
Member Author

sternenseemann commented Oct 8, 2025

Ref #445447

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 9, 2025
@06kellyjac
Copy link
Member

06kellyjac commented Oct 9, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 450001
Commit: 74994acd3902b34b707cf0410964224259bf7cf0 (subsequent changes)
Merge: 08440d8d2495bea7dcb63231990c2a955fc2f59d

Logs: https://github.com/06kellyjac/nixpkgs-review-gha/actions/runs/18376990330

x86_64-linux

✅ 1 package built:
  • apvlv

aarch64-linux

✅ 1 package built:
  • apvlv

x86_64-darwin

✅ No rebuilds

aarch64-darwin

✅ No rebuilds

06kellyjac
06kellyjac approved these changes Oct 9, 2025
View reviewed changes
Copy link
Member

@06kellyjac 06kellyjac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved automatically following the successful run of nixpkgs-review.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Oct 9, 2025
vcunat
vcunat previously requested changes Oct 13, 2025
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apvlv.tests got broken as noticed by the CI (and this worked just before cmake upgrade)

@sternenseemann sternenseemann requested a review from vcunat October 13, 2025 11:00
@sternenseemann
Copy link
Member Author

sternenseemann commented Oct 13, 2025

Thanks, resolved.

@sternenseemann sternenseemann dismissed vcunat’s stale review October 13, 2025 11:20

succeeds in CI on x86_64-linux now.

@vcunat vcunat added this pull request to the merge queue Oct 13, 2025
Merged via the queue into NixOS:master with commit 11e9ef3 Oct 13, 2025
29 of 32 checks passed
@sternenseemann sternenseemann deleted the apvlv-0.7.0 branch October 13, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@06kellyjac 06kellyjac 06kellyjac approved these changes

@ardumont ardumont Awaiting requested review from ardumont

@anthonyroussel anthonyroussel Awaiting requested review from anthonyroussel

@vcunat vcunat Awaiting requested review from vcunat

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sternenseemann @06kellyjac @vcunat @SuperSandro2000